Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pr2eus] go-pos-unsafe return t when the motion is correctly executed. #491

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Nov 22, 2022

now :go-pos-unsafe always return nil in kinematics simulation and cmd_vel case.
this PR changes to return t in kinematics simulation and cmd_vel case.

  • kinematics simulation case
    • the robot moves in :go-pos-unsafe-no-wait
    • :go-pos-unsafe-no-wait returns t
    • dont run :go-pos-unsafe-wait because of or
    • so, :go-pos-unsafe returns t
  • cmd_vel case
    • the robot moves in :go-pos-unsafe-no-wait
    • :go-pos-unsafe-no-wait returns t
    • dont run :go-pos-unsafe-wait because of or
    • so, :go-pos-unsafe returns t
  • move_base_trajecotry_action case case
    • the robot publish goal to action in :go-pos-unsafe-no-wait
    • the robot wait for the action in :go-pos-unsafe-wait
    • :go-pos-unsafe-no-wait returns nil
    • :go-pos-unsafe-wait returns t or nil (it depends on action result)
    • so, :go-pos-unsafe returns t or nil (it depends on action result)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pr2eus] :go-pos-unsafe always returns nil in kinematics simualtion and cmd_vel case
1 participant