[pr2eus] go-pos-unsafe return t
when the motion is correctly executed.
#491
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now
:go-pos-unsafe
always returnnil
inkinematics simulation
andcmd_vel
case.this PR changes to return
t
inkinematics simulation
andcmd_vel
case.kinematics simulation
case:go-pos-unsafe-no-wait
:go-pos-unsafe-no-wait
returnst
:go-pos-unsafe-wait
because ofor
:go-pos-unsafe
returnst
cmd_vel
case:go-pos-unsafe-no-wait
:go-pos-unsafe-no-wait
returnst
:go-pos-unsafe-wait
because ofor
:go-pos-unsafe
returnst
move_base_trajecotry_action case
casegoal
toaction
in:go-pos-unsafe-no-wait
action
in:go-pos-unsafe-wait
:go-pos-unsafe-no-wait
returnsnil
:go-pos-unsafe-wait
returnst
ornil
(it depends onaction result
):go-pos-unsafe
returnst
ornil
(it depends onaction result
)