-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pr2eus_tutorials] add pr2 tabletop demo test and sample #341
[pr2eus_tutorials] add pr2 tabletop demo test and sample #341
Conversation
…nch file as real robot
…e model and positions for demo
Sorry, but since someone brakes pcl_ros, I think travis will not pass this
PR until monday, So until they fixed pcl_ros, I think you can start with
https://github.com/jsk-enshu/robot-programming/ with @tongtybj, it is well
tested and has good documentation. Spend 5 days with that courses, and them
move to PR2 robot. Or you first teach how to set remotes and swap branches.
note that all new B4 learned everything with 16.04. They started bring up
program within robot embedded computer with indigo, but launched and used
their application program with their kinetic machine.
Of cause, you can skip kinetic and then start using 18.04 from next year,
but you have to keep answering "why we are not using 16.04.." question
…--
◉ Kei Okada
2018-04-08 14:27 GMT+09:00 Shingo Kitagawa <[email protected]>:
I updated #217 <#217> and
work in PR2 indigo.
@k-okada <https://github.com/k-okada> We want to use this tutorials this
Monday. Can you review and merge this?
------------------------------
You can view, comment on, or merge this pull request online at:
#341
Commit Summary
- [pr2eus_tutorials] rename to pr2_tabletop.rviz
- [pr2eus_tutorials/launch/gazebo/pr2_tabletop_sim.launch] use same
launch file as real robot
- [pr2eus_tutorials/launch/gazebo/spawn_model_in_database.launch]
change model and positions for demo
- [pr2eus_tutorials] add test code for pr2_tabletop
- [pr2eus_tutorials] add readme and sample code for pr2 tabletop
- [pr2eus_tutorials] add pr2 tabletop_object_detect launch with
jsk_pcl_ros
- [pr2eus_tutorials] add pr2_tabletop_object_grasp demo launch
- [pr2eus_tutorials/sample/pr2-tabletop-sample.l] remove unneccesary
code
- [pr2eus_tutorials/package.xml] add missing dependencies
- [pr2eus_tutorials] use jsk stuff for gazebo scene
- update kinect topic message name
- fix typo in README.md
File Changes
- *M* pr2eus_tutorials/CMakeLists.txt
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-0> (5)
- *M* pr2eus_tutorials/README.md
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-1> (30)
- *R* pr2eus_tutorials/config/pr2_tabletop.rviz
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-2>
(465)
- *A* pr2eus_tutorials/euslisp/pr2-tabletop-object-grasp.l
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-3>
(153)
- *M* pr2eus_tutorials/launch/gazebo/pr2_gazebo_empty.launch
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-4> (2)
- *A* pr2eus_tutorials/launch/gazebo/pr2_tabletop_grasp_sim.launch
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-5> (12)
- *A* pr2eus_tutorials/launch/gazebo/pr2_tabletop_grasp_sim.sh
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-6> (7)
- *A* pr2eus_tutorials/launch/gazebo/pr2_tabletop_scene.launch
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-7> (10)
- *M* pr2eus_tutorials/launch/gazebo/pr2_tabletop_sim.launch
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-8> (29)
- *A* pr2eus_tutorials/launch/gazebo/pr2_tabletop_sim.sh
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-9> (7)
- *M* pr2eus_tutorials/launch/gazebo/spawn_objects.launch
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-10> (9)
- *M* pr2eus_tutorials/launch/pr2_tabletop.launch
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-11>
(25)
- *A* pr2eus_tutorials/launch/pr2_tabletop_grasp.launch
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-12>
(26)
- *M* pr2eus_tutorials/package.xml
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-13> (6)
- *A* pr2eus_tutorials/test/test-pr2-tabletop.l
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-14>
(36)
- *A* pr2eus_tutorials/test/test_pr2_tabletop_sim.test
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-15>
(13)
- *A* pr2eus_tutorials/worlds/tabletop.world
<https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341/files#diff-16>
(51)
Patch Links:
- https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341.patch
- https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/341.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#341>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3HHfIMLxuVddN_kX8Td1zCeh4r0tks5tmZ_FgaJpZM4TLZS4>
.
|
@k-okada
OK, I will use the branch and do the demonstration with M1.
I think we need to move to 16.04 in this year. It would be a big issue, but we have to complete it. |
Some B4 students use PR2 with kinetic in your seminar, but how do they
use it?
everyone used from kinetic, see
jsk-ros-pkg/jsk_demos#1226 for old information
and better solution can be find
jsk-ros-pkg/jsk_robot#898
…--
◉ Kei Okada
2018-04-08 23:20 GMT+09:00 Shingo Kitagawa <[email protected]>:
@k-okada <https://github.com/k-okada>
Thank you for replying.
Sorry, but since someone brakes pcl_ros, I think travis will not pass this
PR until monday, So until they fixed pcl_ros, I think you can start with
https://github.com/jsk-enshu/robot-programming/ with @tongtybj
<https://github.com/tongtybj>, it is well
tested and has good documentation. Spend 5 days with that courses, and them
move to PR2 robot. Or you first teach how to set remotes and swap branches.
OK, I will use the branch and do the demonstration with M1.
note that all new B4 learned everything with 16.04. They started bring up
program within robot embedded computer with indigo, but launched and used
their application program with their kinetic machine.
Of cause, you can skip kinetic and then start using 18.04 from next year,
but you have to keep answering "why we are not using 16.04.." question
I think we need to move to 16.04 in this year. It would be a big issue,
but we have to complete it.
Some B4 students use PR2 with kinetic in your seminar, but how do they use
it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#341 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3EyQmVbLwuU_7yIwVD7YeSrpeByqks5tmhyQgaJpZM4TLZS4>
.
|
I will do this demo for M1 with you from tomorrow and keep improving jsk-enshu (it is my job). |
upstream was fixed, but test is failing
|
Move to #217 |
I updated #217 and work in PR2 indigo.
@k-okada We want to use this tutorials this Monday. Can you review and merge this?