Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP/wontfix] :angle-vector change :start-time as keyward arguments #302

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Jun 22, 2017

I think this is too late but when I see https://github.com/jsk-ros-pkg/jsk_robot/pull/791/files#diff-6ff97bd13d391ef9b8bfd189bd871e65R36 code,
I think we did mistake on :angle-vector arguments

https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/51/files changed like

-   (av &optional (tm 3000) (ctype controller-type))
+   (av &optional (tm 3000) (ctype controller-type) (start-time 0))

and https://github.com/jsk-ros-pkg/jsk_pr2eus/pull/85/files changed

-   (av &optional (tm 3000) (ctype controller-type) (start-time 0))
+   (av &optional (tm nil) (ctype controller-type) (start-time 0) &key (scale 5) (min-time 1.0))

@knorth55
Copy link
Member

knorth55 commented Jun 22, 2017

in pr2eus_moveit, controller-type is also keyword argument.
I want to standardize :angle-vector arguments.

(:angle-vector-motion-plan
  (av &rest args &key (ctype controller-type) (start-offset-time) (total-time)
         (move-arm :larm) (reset-total-time 5000.0) (use-send-angle-vector) (scale 1.0)
         &allow-other-keys)

https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/master/pr2eus_moveit/euslisp/robot-moveit.l#L526-L527

@k-okada
Copy link
Member Author

k-okada commented Jun 22, 2017

@snozawa @YoheiKakiuchi I'd like to know the impact of this change. they already use av tm ctype case, but rarely using av tm ctype start-time ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants