Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Package.xml] Resolve dependency to other package #610

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

sugikazu75
Copy link
Contributor

@tongtybj
Copy link
Collaborator

LGTM, but what kind of error did you encounter without this patch? @sugikazu75

@tongtybj tongtybj changed the title Resolve dependency to other package [Package.xml] Resolve dependency to other package Apr 14, 2024
@sugikazu75
Copy link
Contributor Author

@tongtybj When I want to calibrate spinal and built only spinal, I encountered error. So I fixed it and other packages too.

@tongtybj tongtybj self-requested a review April 14, 2024 12:38
@sugikazu75
Copy link
Contributor Author

I also would like to add dependancy to jsk_tools (and jsk_visualization).
How do you think about it?

@tongtybj
Copy link
Collaborator

Are we using nodes or plugin related to jsk_tools or jsk_visualization in our system?

@sugikazu75
Copy link
Contributor Author

sugikazu75 commented Apr 14, 2024

I suggested it because when we use real machine, we install jsk_tools manually, but they are not related to directry to our system, so please ignore it.

@tongtybj tongtybj merged commit 7ac7184 into jsk-ros-pkg:master Apr 15, 2024
6 checks passed
tongtybj pushed a commit to tongtybj/aerial_robot that referenced this pull request May 19, 2024
commit 7ac7184
Merge: e11261e 212c717
Author: 趙 漠居(Zhao, Moju) <[email protected]>
Date:   Mon Apr 15 09:57:03 2024 +0900

    Merge pull request jsk-ros-pkg#610 from sugikazu75/PR/package/depend

    [Package.xml] Resolve dependency to other package
tongtybj pushed a commit to tongtybj/aerial_robot that referenced this pull request May 20, 2024
commit 7ac7184
Merge: e11261e 212c717
Author: 趙 漠居(Zhao, Moju) <[email protected]>
Date:   Mon Apr 15 09:57:03 2024 +0900

    Merge pull request jsk-ros-pkg#610 from sugikazu75/PR/package/depend

    [Package.xml] Resolve dependency to other package
@sugikazu75 sugikazu75 deleted the PR/package/depend branch June 15, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants