Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commandkit.js.org #8512

Merged
merged 1 commit into from
Sep 15, 2023
Merged

commandkit.js.org #8512

merged 1 commit into from
Sep 15, 2023

Conversation

notunderctrl
Copy link
Contributor

@notunderctrl notunderctrl changed the title Update cnames_active.js commandkit.js.org Sep 14, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://commandkit.netlify.app/

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages labels Sep 14, 2023
@indus indus added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Sep 14, 2023
@indus
Copy link
Member

indus commented Sep 14, 2023

I've already added your requested subdomain to JS.ORGs zonefile. You may have to configure your host to accept the custom domain.
I'll merge after we have "contact". Please keep this PR open.

@notunderctrl
Copy link
Contributor Author

I've configured netlify to accept this domain @indus and it seems to be working.
Thanks!

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Sep 15, 2023
@indus
Copy link
Member

indus commented Sep 15, 2023

Welcome https://commandkit.js.org

@indus indus merged commit 1f20312 into js-org:master Sep 15, 2023
1 check passed
@notunderctrl notunderctrl deleted the patch branch January 2, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants