Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

megdb.js.org #8452

Merged
merged 4 commits into from
Aug 22, 2023
Merged

megdb.js.org #8452

merged 4 commits into from
Aug 22, 2023

Conversation

MegalithOfficial
Copy link
Contributor

@MegalithOfficial MegalithOfficial changed the title Update cnames_active.js megdb.js.org Aug 21, 2023
MattIPv4
MattIPv4 requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the CI error notes, you entry needs to be in alphabetical order

@MegalithOfficial
Copy link
Contributor Author

now its fixed i guess.
May i ask why its important to be in alphabetical order?

@MattIPv4
Copy link
Member

Keeping everything in alphabetical order reduces conflicts with multiple people making PRs, and keeps the file organised :)

@MegalithOfficial
Copy link
Contributor Author

now it should be

@indus
Copy link
Member

indus commented Aug 22, 2023

I removed the duplicate.
Welcome https://megdb.js.org

@indus indus merged commit af74ca8 into js-org:master Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MegalithOfficial @MattIPv4 @indus