Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

novalib.js.org #8445

Closed
wants to merge 4 commits into from
Closed

novalib.js.org #8445

wants to merge 4 commits into from

Conversation

M1dnight-ofcl
Copy link
Contributor

@MattIPv4 MattIPv4 changed the title added "novalib" novalib.js.org Aug 19, 2023
MattIPv4
MattIPv4 requested changes Aug 19, 2023
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the CI error indicates, your entry needs to be in alphabetical order and does not need the https:// prefix

@indus
Copy link
Member

indus commented Aug 21, 2023

@M1dnight-ofcl I've fixed the alphabetical order, but can you show me a preview of the page to give me chance to get an idea what it is that should get added?

@M1dnight-ofcl
Copy link
Contributor Author

Ok

@M1dnight-ofcl
Copy link
Contributor Author

The image wouldnt load since i am away from home.Screenshot_20230821-104823_Opera GX.jpg

@M1dnight-ofcl
Copy link
Contributor Author

Here is another image with unloaded image i mentioned earlierScreenshot_20230821-104940_Opera GX.jpg

@indus
Copy link
Member

indus commented Aug 21, 2023

@M1dnight-ofcl By reading your about text I don't see how this is related to JavaScript.

You may want to use one of the similar services that may fit better.

@indus indus closed this Aug 22, 2023
@indus indus added unrelated / unqualified the content of the page is unrelated to JS, is a personal blog or unqualified for another reason and removed invalid labels Aug 22, 2023
@M1dnight-ofcl M1dnight-ofcl deleted the M1dnight-ofcl-patch-1 branch August 27, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees
No one assigned
Labels
unrelated / unqualified the content of the page is unrelated to JS, is a personal blog or unqualified for another reason
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M1dnight-ofcl @indus @MattIPv4