Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automata.js.org #8372

Merged
merged 3 commits into from
Jul 16, 2023
Merged

automata.js.org #8372

merged 3 commits into from
Jul 16, 2023

Conversation

notscrappie
Copy link
Contributor

Will be used for the documentation page of Automata. You can check the website hosted on Vercel here: https://automata-shadowrunners.vercel.app. Don't know if I set it up correctly so let me know!

MattIPv4
MattIPv4 requested changes Jul 14, 2023
View reviewed changes
cnames_active.js Outdated Show resolved Hide resolved
MattIPv4
MattIPv4 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://automata-shadowrunners.vercel.app/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain and removed invalid labels Jul 14, 2023
@indus indus added external page This PR has a target of a site that isn't GitHub Pages error The page requested returns an error labels Jul 16, 2023
@indus
Copy link
Member

indus commented Jul 16, 2023

@notscrappie sorry for the long delay. I've added your requested subdomain to JS.ORGs zonefile. But Iget redirected to www.automata.js.org which does not exist. You may have to configure your host.
I'll merge after we have "contact". Please keep this PR open.

@notscrappie
Copy link
Contributor Author

@notscrappie sorry for the long delay. I've added your requested subdomain to JS.ORGs zonefile. But Iget redirected to www.automata.js.org which does not exist. You may have to configure your host. I'll merge after we have "contact". Please keep this PR open.

No worries! I removed the record that was redirecting to the www version of the domain and it now works. Thanks for adding my subdomain!

@indus indus removed the error The page requested returns an error label Jul 16, 2023
@indus
Copy link
Member

indus commented Jul 16, 2023

Welcome https://automata.js.org

@indus indus merged commit 924d786 into js-org:master Jul 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notscrappie @indus @MattIPv4