Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quotes.js.org #8347

Closed
wants to merge 1 commit into from
Closed

quotes.js.org #8347

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cnames_active.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2322,6 +2322,7 @@
"quiz-app": "odevlord.github.io/Quiz-App", // noCF? (don´t add this in a new PR)
"quizizz": "zaida04.github.io/Quizizz.js",
"quizlet": "redyetidev.github.io/Quizlet.JS",
"quotes": "https://qts-xi.vercel.app",

Check failure on line 2325 in cnames_active.js

View workflow job for this annotation

GitHub Actions / validate 

Expected: `  "quotes": "cname.vercel-dns.com", // noCF`
   Found: `  "quotes": "https://qts-xi.vercel.app",`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"quotes": "https://qts-xi.vercel.app",
"quotes": "cname.vercel-dns.com", // noCF

As the CI error notes, when using Vercel you should target this hostname rather than your app, and you should request the Cloudflare proxy be disabled with the // noCF comment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I committed new one

"quotobot": "team-gigabyte.github.io/quotobot",
"r": "r-js.github.io",
"ractive": "ractivejs.github.io",
Expand Down
Loading