ROS 2 file generation macro #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nim65s
requested changes
Oct 4, 2024
for more information, see https://pre-commit.ci
Done. Thanks for the review @nim65s ! |
nim65s
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix #716.
This PR introduces a new file ros2.cmake.
It provides a macro _install_project_ros2_ament_files to generate files for the ROS2 ament system.
This macro is called in setup_project_finalize() in base.cmake.
The generation works if the variable BUILDING_ROS2_PACKAGE is set (to TRUE
for instance).
pre-commit was run over the PR.
Tested against unittest.