Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CXX_FLAGS_BY_COMPILER_FRONTEND function #659

Merged

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Jan 26, 2024

This function allow to choose different compiler options or definitions based on the compiler frontend

@jorisv jorisv self-assigned this Jan 26, 2024
@jorisv jorisv marked this pull request as draft January 26, 2024 15:38
@jorisv jorisv marked this pull request as ready for review January 26, 2024 15:48
@jorisv
Copy link
Contributor Author

jorisv commented Jan 26, 2024

We can maybe use this function in _SETUP_PROJECT_WARNINGS

@jorisv jorisv marked this pull request as draft January 26, 2024 17:00
@jorisv jorisv marked this pull request as ready for review January 29, 2024 08:56
Copy link
Collaborator

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for a misleading comment

compiler.cmake Outdated Show resolved Hide resolved
@jorisv jorisv merged commit 5e91513 into jrl-umi3218:master Jan 29, 2024
2 checks passed
@jorisv jorisv deleted the topic/cxx_flags_by_compiler_frontend branch January 29, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants