Remove Geometry::scale #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @arntanguy Thanks for the PR I have no problem with it but I suggest we make sure that no code (that we are aware of) relies on |
|
Yes, magnum does, but besides that I am not aware of any other that relies on it. |
gergondet
added a commit
that referenced
this pull request
Feb 5, 2024
* Remove scale in favor of scaleV in visuals (#119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to remove the duplication between
double Geometry::Mesh::scaleandEigen::Vector3d Geometry::Mesh::scaleV. IndeedscaleVcontains all the necessary information and having both is unnecessary and confusing.Loading from
urdf/yamlstill supports both a single valued or dimensional scale. Exporting always exports the dimensional scale.See jrl-umi3218/mc_rtc#430