Added parameter "far" from phpThumb as forceAspectRatio on MeioUpload

[maurogeorge]

The image will be resized to the specified by "width" and "height" do not be cropped and the white-spaces, if image do not be proporcional will be filled. The image always have the value specified on "width" and "height". More information on http://phpthumb.sourceforge.net/demo/docs/phpthumb.readme.txt search for "far".

[maurogeorge]

Hi Juan,

why pull my request was not accepted? The something extra that I do? Because I believe it is a useful utility to the behavior.

Thanks

[josegonzalez]

Can you write some documentation for this? The formatting isn't so important, that can be fixed later. I'll pull it in once you have docs.

[maurogeorge]

Hi,

josegonzalez sorry about the delay. I created on page on wiki with info about the feature i have created and about the creating of thumbnails on https://github.com/jrbasso/MeioUpload/wiki/Creating-thumbnails.

Sorry about my poor english if have errors by english if possible you correct, I appreciate

[josegonzalez]

Awesome, love it. If you could add the docs to the readme (just make a section, don't worry that there isn't one already) I'll love you forever!

Any and all contribs are welcome, especially those with docs :)

[maurogeorge]

Hi, I added the section in the readme. is it right?

[maurogeorge]

Folks, that's okay to accept the pull request? Why that currently has information on the wiki that are not actually in the plugin https://github.com/jrbasso/MeioUpload/wiki/Creating-thumbnails that I added as requested.

[louiscoetzee]

Hi, was this ever implemented into MeioUpload, I do not see it in the code, but there was documentation created for it?

[maurogeorge]

@ louiscoetzee if you read the whole thread you will see that I was asked to create the documentation, I created the wiki and then went to the readme. After doing the required, the pull the request was not accepted, my last post was #77 (comment) as we have spent a year after that, perhaps not even make sense anymore. I commend the staff of the project to close it here, it no longer makes sense.

[louiscoetzee]

Hi, okay cool thanks, after I posted I downloaded your code. It was very
unclear from the dcumentation that your pull request was not accepted, I
was under the impression that it was implemented in the final code. But
anyway, got it from your version, and it works great, exactly what I needed.

Thanks.

On Mon, Jul 16, 2012 at 2:51 PM, Mauro George <
[email protected]

wrote:

@ louiscoetzee if you read the whole thread you will see that I was asked
to create the documentation, I created the wiki and then went to the
readme. After doing the required, the pull the request was not accepted, my
last post was
#77 (comment) as we
have spent a year after that, perhaps not even make sense anymore. I
commend the staff of the project to close it here, it no longer makes sense.

---

Reply to this email directly or view it on GitHub:
#77 (comment)

[maurogeorge]

Yeah, I know it is not clear from the documentation, I said that on the link in the previous comment for the folks.
Glad it worked, maybe the folks accept the pull request. I do not know why it was never accepted, had no further comment here, but I commend the staff of the project to close it here, it no longer makes sense.