Add support for Musl (#429) #430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change import to allow a choice between Glibc and Musl musl pow ref: https://git.musl-libc.org/cgit/musl/tree/include/math.h
lynchsft
reviewed
Sep 25, 2024
| #elseif canImport(Musl) | ||
| import CoreFoundation | ||
| import Musl | ||
| private let cpow: (_: Double, _: Double) -> Double = Musl.pow |
There was a problem hiding this comment.
Weren't native Swift math functions added to the STL in 2019?
https://github.com/swiftlang/swift/pull/23140/files
Do we still need to import any C libraries here?
There was a problem hiding this comment.
Looking at the background to the introduction of this, it now seems like it would be okay to use STL math functions. In that case, we would need to check that there are no problems with all toolchains. If we are only going to support Musl, I think it would have less of an impact if you just explicitly loaded cpow.
introduce commit: 682d498
commit message:
We must disambiguate `Double.pow(_: Double, _: Double) -> Double` and
`__C.pow(_: Double, _: Double) -> Double` as the Swift for TensorFlow
branch adds the former into the standard library. The explicit module
dispatch ensures that we make the overload resolution unambiguous
allowing building Yams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Change import to allow a choice between Glibc and Musl.
related Issue: #429
replacing musl pow: https://git.musl-libc.org/cgit/musl/tree/include/math.h
Check