Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest kinetic plate-reder files from Tecan i-control #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tp2750
Copy link

@tp2750 tp2750 commented Jul 20, 2018

As discussed over at https://discuss.ropensci.org/t/plate-reader-files/1192/16

Here's a shot at ingesting a plate-reader file from Tecan i-control.

I have tried to follow the guidelines for code-style for the exported function.
It uses some existing functions in a different style. Hope that is OK.

The header data.frame contains fields "Date", "Time", "Start Time" that might look as they should be date-times. They are strings in the Excel-file, and I suspect the format depends on the locale of the computer running i-control, so I chose to leave them as strings.

@jpshanno
Copy link
Owner

jpshanno commented Jul 23, 2018

Thanks @tp2750! Everything looks pretty good in the code, I just have to check out why the builds are failing. But we're actually in the process of working out some details about how we deal with reading in the header data and linking it to the data. I am going to let this sit for just a little bit until we get our new approach standardized (shouldn't be too long).

@jpshanno
Copy link
Owner

jpshanno commented Nov 6, 2018

Thanks for being patient while we sorted out how we were going to handle temporary files. We've changed it around so that header information is now stored in a temporary file and can be retrieved with the ingest_header() function. The example file's been updated to show that now if there's header info it just needs to be formatted and then run with export_header(). I'm going to be working on the project for most of Wednesday, 11/14, with a zoom line up from at least 10:00 EST - 3:00 EST (https://ucsb.zoom.us/j/966777885). If you are interested in updating what you have done we should be able to get the pull request approved soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants