Fixed FieldValue#toString() method for non-scalars

jpmml · Jul 7, 2024 · 7bfed14 · 7bfed14
1 parent 6ceb43d
commit 7bfed14
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pmml-evaluator/src/main/java/org/jpmml/evaluator/FieldValue.java b/pmml-evaluator/src/main/java/org/jpmml/evaluator/FieldValue.java
@@ -325,7 +325,6 @@ protected ToStringHelper toStringHelper(){
 		ToStringHelper helper = new ToStringHelper(this)
 			.add("opType", getOpType())
 			.add("dataType", getDataType())
-			.add("valid", isValid())
 			.add("value", getValue());
 
 		return helper;

diff --git a/pmml-evaluator/src/main/java/org/jpmml/evaluator/ScalarValue.java b/pmml-evaluator/src/main/java/org/jpmml/evaluator/ScalarValue.java
@@ -19,6 +19,7 @@
 package org.jpmml.evaluator;
 
 import org.dmg.pmml.DataType;
+import org.jpmml.model.ToStringHelper;
 
 abstract
 public class ScalarValue extends FieldValue implements Comparable<ScalarValue> {
@@ -87,6 +88,14 @@ public int compareTo(ScalarValue that){
 		return compareToValue(that);
 	}
 
+	@Override
+	protected ToStringHelper toStringHelper(){
+		ToStringHelper helper = super.toStringHelper()
+			.add("valid", isValid());
+
+		return helper;
+	}
+
 	static
 	private Object filterValue(Object value){