-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: maintain coding style using PHP Code Sniffer #469
base: master
Are you sure you want to change the base?
Conversation
omit use of call_user_func_array remove error suppression
6797bd4
to
39f239f
Compare
39f239f
to
0f5a5fd
Compare
It would be ideal to conform to PSR-2... but that would be a huge BC break, since it would require changing the name of every single method. Lol. In the meantime, its still better to ensure that we maintain the somewhat strange style of this project than have mixed YOLO styles. :P |
Here's a convenient review link to review the changes while ignoring whitespace: |
This looks good to me 👍 |
Does PSR requires a coding style for method names? I'd though it was only for project/class structures. But I did not read into it at all, so don't know.. |
Yea. PSR-2 is an extension of PSR-1, which requires method names to be camel-cased: |
PSR-2 will need to wait until a major point release where BC will not be an issue. As for tabs and spaces, let's go with 4 spaces. I believe @jpfuentes2 is on board with that as well. |
Added PHP Code Sniffer as composer dependency and to Travis config.
This is probably the time to switch to more sensible defaults:
tabs or spaces
OpeningFunctionBraceBsdAllman or OpeningFunctionBraceKernighanRitchie