Add support for multiple issuers #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
jpadilla
requested changes
Mar 18, 2021
| @@ -212,7 +212,10 @@ def _validate_iss(self, payload, issuer): | |||
| if "iss" not in payload: | |||
| raise MissingRequiredClaimError("iss") | |||
|
|
|||
| if payload["iss"] != issuer: | |||
| if isinstance(issuer, str): | |||
There was a problem hiding this comment.
do we also need to guard against other invalid values for issuer?
see https://github.com/jpadilla/pyjwt/blob/master/jwt/api_jwt.py#L128-L129
dimaqq
reviewed
Mar 19, 2021
|
I'm interested in this feature. |
Co-authored-by: Dima Tisnek <[email protected]>
for more information, see https://pre-commit.ci
That makes two of us. |
|
@jpadilla is support for multiple issuers coming soon? |
|
there were some unresolved comments on this pull request, I'd gladly review again another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #433
This PR adds support for specifing multiple issuers, similar to what we do for audience.