This repository has been archived by the owner on May 26, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 651
Pass Request from JSONWebTokenSerializer to django.contrib.auth #412
Open
jksimoniii
wants to merge
5
commits into
jpadilla:master
Choose a base branch
from
jksimoniii:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
- Coverage 90.67% 90.41% -0.27%
==========================================
Files 14 12 -2
Lines 847 824 -23
Branches 29 29
==========================================
- Hits 768 745 -23
Misses 66 66
Partials 13 13
Continue to review full report at Codecov.
|
This was referenced Dec 21, 2017
Closed
gbarbaten
approved these changes
Jan 3, 2018
Any updates on this? |
+1 |
2 similar comments
+1 |
+1 |
@jpadilla is it possible to merge this PR into master? |
paymog
reviewed
Nov 27, 2019
@@ -29,9 +33,14 @@ def setUp(self): | |||
'password': self.password | |||
} | |||
|
|||
def get_serializer(self, **kwargs): | |||
serializer = JSONWebTokenSerializer(**kwargs) | |||
serializer.context['request'] = Request(HttpRequest()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the ,
at the end of this line a mistake? That creates a tuple for the value of serializer.context['request']
which doesn't seem quite right
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #387