Skip to content
This repository has been archived by the owner on May 26, 2020. It is now read-only.

Fixes #290 -- Pass request object on authenticate() #395

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jezeniel
Copy link

@jezeniel jezeniel commented Nov 7, 2017

Django 1.11 introduced def authenticate(request, ...).
This would be useful for some authentications with additional data.
i.e. multiple user types.

@jezeniel
Copy link
Author

jezeniel commented Nov 7, 2017

Need opinions and tips on how to add test case for this one.

Django 1.11 introduced def authenticate(request, ...).
This would be useful for some authentications with additional data.
i.e. multiple user types.
@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #395 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   90.67%   90.73%   +0.06%     
==========================================
  Files          14       14              
  Lines         847      853       +6     
  Branches       29       30       +1     
==========================================
+ Hits          768      774       +6     
  Misses         66       66              
  Partials       13       13
Flag Coverage Δ
#codecov 90.73% <100%> (+0.06%) ⬆️
#dj110 87.33% <80%> (-0.15%) ⬇️
#dj111 87.33% <80%> (-0.15%) ⬇️
#dj18 89.68% <80%> (-0.17%) ⬇️
#dj19 89.68% <80%> (-0.17%) ⬇️
#drf31 89.68% <80%> (-0.17%) ⬇️
#drf32 89.68% <80%> (-0.17%) ⬇️
#drf33 89.68% <80%> (-0.17%) ⬇️
#drf34 90.73% <100%> (+0.06%) ⬆️
#drf35 90.38% <100%> (+0.06%) ⬆️
#drf36 90.38% <100%> (+0.06%) ⬆️
#py27 90.73% <100%> (+0.06%) ⬆️
#py33 89.33% <80%> (-0.17%) ⬇️
#py34 90.38% <100%> (+0.89%) ⬆️
#py35 87.57% <100%> (?)
#py36 87.57% <100%> (?)
Impacted Files Coverage Δ
rest_framework_jwt/compat.py 78.57% <100%> (+4.65%) ⬆️
rest_framework_jwt/serializers.py 82.6% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0bd40...20594c5. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Nov 7, 2017

Codecov Report

Merging #395 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   90.67%   90.73%   +0.06%     
==========================================
  Files          14       14              
  Lines         847      853       +6     
  Branches       29       30       +1     
==========================================
+ Hits          768      774       +6     
  Misses         66       66              
  Partials       13       13
Flag Coverage Δ
#codecov 90.73% <100%> (+0.06%) ⬆️
#dj110 87.33% <80%> (-0.15%) ⬇️
#dj111 87.33% <80%> (-0.15%) ⬇️
#dj18 89.68% <80%> (-0.17%) ⬇️
#dj19 89.68% <80%> (-0.17%) ⬇️
#drf31 89.68% <80%> (-0.17%) ⬇️
#drf32 89.68% <80%> (-0.17%) ⬇️
#drf33 89.68% <80%> (-0.17%) ⬇️
#drf34 90.73% <100%> (+0.06%) ⬆️
#drf35 90.38% <100%> (+0.06%) ⬆️
#drf36 90.38% <100%> (+0.06%) ⬆️
#py27 90.73% <100%> (+0.06%) ⬆️
#py33 89.33% <80%> (-0.17%) ⬇️
#py34 90.38% <100%> (+0.89%) ⬆️
#py35 87.57% <100%> (?)
#py36 87.57% <100%> (?)
Impacted Files Coverage Δ
rest_framework_jwt/compat.py 78.57% <100%> (+4.65%) ⬆️
rest_framework_jwt/serializers.py 82.6% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0bd40...20594c5. Read the comment docs.

@jezeniel
Copy link
Author

Any updates for this one?

@zgyarmati
Copy link

I vote for this, as it also affects me, and the patch works for me well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants