Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add spanish translation for /tutorial #53

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rafnixg
Copy link
Contributor

@rafnixg rafnixg commented Dec 14, 2022

  • ADD: spanish translation for getting-started
  • ADD: spanish translation for configurations
  • ADD: spanish translation for validations
  • ADD: spanish translation for authentication
  • ADD: spanish translation for files
  • ADD: spanish translation for batch actions
  • ADD: spanish translation for multiple-admin

@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (67ad65c) compared to base (4a4ce83).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           54        54           
  Lines         3880      3880           
=========================================
  Hits          3880      3880           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jowilf
Copy link
Owner

jowilf commented Dec 14, 2022

Hello @rafnixg,
Thank you for your contribution.
I will take advantage of this PR to setup docs preview with vercel or netlify before merge it.

But I'm also thinking about a better solution to update the translated documentation to follow the main doc. Do you have any suggestion ?

@@ -1,19 +1,16 @@
# Authentication & Authorization
# Autorización de autenticación
Copy link
Owner

@jowilf jowilf Dec 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is out of date

@@ -1,11 +1,10 @@
# ModelView Configurations
# Configuraciones de ModelView
Copy link
Owner

@jowilf jowilf Dec 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

@jowilf jowilf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rafnixg,

Thank you for your work, i made some few comments can you check them ?

Also i notice that mkdocs-static-i18n didn't works well with some mkdocs plugins.

For example, this is what we have in english documentation,

en

and this is what we have in spanish documentation

es

This can be a real problem in long term basic, we could be blocked by mkdocs-static-i18n when mkdocs-material release a new version.

Take a look at this -> squidfunk/mkdocs-material#2346

@hasansezertasan
Copy link
Contributor

hasansezertasan commented Oct 21, 2023

Hello @rafnixg,

Thank you for your work, i made some few comments can you check them ?

Also i notice that mkdocs-static-i18n didn't works well with some mkdocs plugins.

For example, this is what we have in english documentation,

en

and this is what we have in spanish documentation

es

This can be a real problem in long term basic, we could be blocked by mkdocs-static-i18n when mkdocs-material release a new version.

Take a look at this -> squidfunk/mkdocs-material#2346

@jowilf
I have finished the translation process to Turkish Language and I'm facing with same issue. Do you have a fix for it? I'm really excited to share it with the world!

Edit: I'm also translating FastAPI Documentation, it's structure is neat. but a bit of complex, I would recommend checking it.

@hasansezertasan
Copy link
Contributor

This PR is quite old and outdated. None of the requested changes are satisfied. @rafnixg are you planning to work on this?

@rafnixg
Copy link
Contributor Author

rafnixg commented Jan 2, 2024

I would indeed be interested in supporting the translation, but it wasn't clear to me what the mechanism or the way to proceed would be. You mentioned that mkdocs-static-i18n had issues with other plugins; has this been resolved? I would like to be able to translate and disseminate content in Spanish.

@hasansezertasan
Copy link
Contributor

hasansezertasan commented Jan 2, 2024

Happy to see you are still interested in it, I thought this PR was abandoned because you haven't said anything since December 2022. I wanted your attention. 🤫

As far as I know, @jowilf is planning to resolve the issue but it's not there yet. I'm sure the author, seeing two such enthusiastic people in the translation process, you and me, will be motivated to resolve the issue.

Note: I sure tried to resolve the issue myself but couldn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants