fix: mcache Malloc should repect capacity

joway · Jun 7, 2024 · 65caa4f · 65caa4f
1 parent 21ff3be
commit 65caa4f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/lang/mcache/mcache.go b/lang/mcache/mcache.go
@@ -68,7 +68,7 @@ func Malloc(size int, capacity ...int) []byte {
 
 	sizeIdx := calcIndex(c)
 	var ret = caches[sizeIdx].Get().([]byte)
-	ret = ret[:size]
+	ret = ret[:size:c]
 	return ret
 }
 

diff --git a/lang/mcache/mcache_test.go b/lang/mcache/mcache_test.go
@@ -22,11 +22,16 @@ import (
 
 func TestMalloc(t *testing.T) {
 	// cached by mcache
-	size := 4096 - 1
-	buf := Malloc(size)
+	size := 128
+	buf := Malloc(size, size+1)
 	assert.Equal(t, len(buf), size)
 	assert.Equal(t, cap(buf), size+1)
-	_ = buf[:size+1] // resize
+
+	// cached by mcache
+	size = 4096 - 1
+	buf = Malloc(size)
+	assert.Equal(t, len(buf), size)
+	assert.Equal(t, cap(buf), size)
 	Free(buf)
 
 	// cached by mcache