fix errors when running ./tests/custom/run_tests.sh on Macos #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErwanMAS
commented
Oct 19, 2023
•
ErwanMAS
commented
- set LC_ALL=C
- generate the tempdir differently so this working on Macos ( still working on linux )
- keep the tempdir when we have a failure
- fix difference on uc_index because of difference of implementation of memmem between Linux/MacOs
- add a regeression test for readlink
ErwanMAS
changed the title
ErwanMAS
force-pushed
the
improve_test_on_macos
branch
from
7f9e809
to
7193cf5
Compare
|
Hi @nbd168 , |
jow-
added a commit
that referenced
this pull request
Nov 1, 2023
On macOS, the `memmem()` function returns `NULL` instead of the expected start of the haystack string when given a zero-length needle argument. Add special case handling for a zero-length needle argument to ensure that the expected offset `0` is returned on all systems. Ref: #176 Suggested-by: Erwan MAS <[email protected]> Signed-off-by: Jo-Philipp Wich <[email protected]>
ErwanMAS
force-pushed
the
improve_test_on_macos
branch
from
c68d63a
to
464ed1a
Compare
set LC_ALL=C to avoid utf8 warning on macos generate the tempdir differently so this working on Macos ( still working on linux ) keep the tempdir when we have a failure add a regeression test for readlink
ErwanMAS
force-pushed
the
improve_test_on_macos
branch
from
464ed1a
to
7472bb1
Compare
|
@jow- , i updated this PR because i saw you fixed the issue with memmem . I tested this on Macos 13.6 and on Debian Bookwork . On both systems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.