Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add regex entity type to NLP.js #93

Merged
merged 1 commit into from
Jan 31, 2024
Merged

✨ Add regex entity type to NLP.js #93

merged 1 commit into from
Jan 31, 2024

Conversation

rmtuckerphx
Copy link
Contributor

Proposed changes

Add support for regex entity types in NLP.js model

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@rmtuckerphx rmtuckerphx changed the title ✨ Add regex entity type ✨ Add regex entity type to NLP.js Oct 31, 2023
@jankoenig jankoenig changed the base branch from v4/latest to v4/dev January 30, 2024 13:30
jankoenig
jankoenig approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rmtuckerphx!

@jankoenig jankoenig merged commit 08d9c73 into jovotech:v4/dev Jan 31, 2024
9 checks passed
@jankoenig jankoenig mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswetlow aswetlow aswetlow approved these changes

@jankoenig jankoenig jankoenig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmtuckerphx @jankoenig @aswetlow