Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add isOneShot for Alexa request #1628

Open
wants to merge 3 commits into
base: v4/dev
Choose a base branch
from

Conversation

sadlowskij
Copy link
Contributor

Proposed Changes

This adds a function to check for so called one shots. Is this something that would be useful? We sometimes differ how we answer depending on if it is a oneshot or not.

Theoretically this is not exclusive to the alexa platform and could just as well be implemented in the normal JovoRequest. I am not sure though, if this always makes sense, or if the terminology and usefulness binds this to alexa. Feel free to tell me if you find this useful, and if so, where.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants