Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify invite code and redirect to correct view #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jarus
Copy link

@jarus jarus commented Oct 25, 2013

The hunger/verify/ redirect now to the correct view.

@yesimon
Copy link
Collaborator

yesimon commented Oct 26, 2013

This case should be handled in the middleware, which should redirect the user to the page. What is the problem you're running into here?

@jarus
Copy link
Author

jarus commented Oct 26, 2013

My problem was in following case:
If the visitor not signed-in than he got the message "Your invite key is correct" but after he sign-in the code is maybe incorrect because there are no remaining invites anymore.

@yesimon
Copy link
Collaborator

yesimon commented Oct 26, 2013

Perhaps a better approach is to make the verify_invite view login_required, so that the key cannot be verified without signed in status?

@jarus
Copy link
Author

jarus commented Oct 26, 2013

Yes this would be the better user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants