Skip to content

Commit

Permalink
exclude com.google.fonts/check/transformed_components from adobefonts
Browse files Browse the repository at this point in the history
- test seems inappropriate for some cases (e.g. unhinted VFs), see fonttools#3966
- update expected number of tests in adobefonts_test.py:: test_profile_check_set
  • Loading branch information
josh-hadley committed Dec 6, 2022
1 parent f87ed78 commit 12cf485
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Lib/fontbakery/profiles/adobefonts.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@
# "com.google.fonts/check/dotted_circle",
# "com.google.fonts/check/unreachable_glyphs",
# "com.google.fonts/check/STAT_strings",
# "com.google.fonts/check/transformed_components",
# ---
"com.adobe.fonts/check/freetype_rasterizer", # IS_OVERRIDDEN
"com.google.fonts/check/family/win_ascent_and_descent", # IS_OVERRIDDEN
Expand All @@ -194,7 +195,6 @@
"com.google.fonts/check/ots",
"com.google.fonts/check/required_tables",
"com.google.fonts/check/rupee",
"com.google.fonts/check/transformed_components",
"com.google.fonts/check/ttx_roundtrip",
"com.google.fonts/check/unique_glyphnames",
"com.google.fonts/check/whitespace_widths",
Expand Down
2 changes: 1 addition & 1 deletion tests/profiles/adobefonts_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def test_get_family_checks():
def test_profile_check_set():
"""Confirm that the profile has the correct number of checks and the correct
set of check IDs."""
assert len(SET_EXPLICIT_CHECKS) == 79
assert len(SET_EXPLICIT_CHECKS) == 78
explicit_with_overrides = sorted(
f"{check_id}{OVERRIDE_SUFFIX}" if check_id in OVERRIDDEN_CHECKS else check_id
for check_id in SET_EXPLICIT_CHECKS
Expand Down

0 comments on commit 12cf485

Please sign in to comment.