Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tallyarbiter-m5atom.ino #688

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

themusicnerd
Copy link
Contributor

Changes:

  • Autorotation! Display will now display the numbers in the correct orientation during tally changes - added as some of my cameras I mount using a stiff USB cable into a v-mount battery
  • Colours from TallyArbiter now are correct
    • Changed GRB_COLOR to RGB_COLOR as someone else changed the values to read RGB instead of GRB
    • Swapped R&G Channels in the HEX converter
    • Added the following colors "WarmWhite" "DIMWarmWhite"
    • Reduced the RGB_COLOR_GREEN as green was significantly brighter than RED or BLUE
  • Continued to add more inconsistant comments
    • fixed several spelling mistakes
    • added several spelling mistakes

To Do:

  • Add persistant Show numbers during tally must be set durning wifi setup
  • Allow setting to allow persistant access to WifiManager during normal operation

Changes:

- Autorotation! Display will now display the numbers in the correct orientation during tally changes - added as some of my cameras I mount using a stiff USB cable into a v-mount battery
- Colours from TallyArbiter now are correct
	- Changed GRB_COLOR to RGB_COLOR as someone else changed the values to read RGB instead of GRB
	- Swapped R&G Channels in the HEX converter
	- Added the following colors "WarmWhite" "DIMWarmWhite"
	- Reduced the RGB_COLOR_GREEN as green was significantly brighter than RED or BLUE
- Continued to add more inconsistant comments
	- fixed several spelling mistakes
	- added several spelling mistakes


To Do:

- Add persistant Show numbers during tally must be set durning wifi setup
- Allow setting to allow persistant access to WifiManager during normal operation
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there themusicnerd 👋

Thank you for opening your first PR for the Tally Arbiter project!

We will review it soon!

TallyArbiter fosters an open and welcoming environment for all our contributors. Please adhere to our Code Of Conduct.

@themusicnerd
Copy link
Contributor Author

Thanks @josephdadams for being awesome with your continued development!
I had some time today to hyperfocus on getting the features I origionally wanted and expand on all the really cool stuff everyone has added to this since I last used it for the first time.
Love how the colours come through from TAServer now!
Hope everyone is well in this great project :D

@Follomon
Copy link

Hi, getting a compile error owhen I set this setting to true (with false everything works fine).

// Set to true if you want to compile with the ability to show camera number during pvw and pgm
#define SHOW_CAMERA_NUMBER_DURING_PVW_AND_PGM true

Thats the error:

...\tallyarbiter-m5atom.ino: In function 'void evaluateMode()':
...\tallyarbiter-m5atom\tallyarbiter-m5atom.ino:366:41: error: invalid conversion from 'int' to 'int*' [-fpermissive]
       drawNumber(rotatedNumber[camNumber], currColor);
                  ~~~~~~~~~~~~~~~~~~~~~~~^
...\tallyarbiter-m5atom\tallyarbiter-m5atom.ino:331:21: note:   initializing argument 1 of 'void drawNumber(int*, int*)'
 void drawNumber(int arr[], int colors[]) {
                 ~~~~^~~~~

exit status 1

Compilation error: invalid conversion from 'int' to 'int*' [-fpermissive]

Thx themusicnerd

@Follomon
Copy link

@themusicnerd I found error in line 366
used your repo file. Sorry I am a newbie.
https://github.com/themusicnerd/TallyArbiter-M5AtomMatrixListener/blob/main/tallyarbiter-m5atom/tallyarbiter-m5atom.ino

366 -          drawNumber(rotatedNumber[camNumber], currColor);
366 +         drawNumber(rotatedNumber, currColor);

@josephdadams josephdadams merged commit 7b80887 into josephdadams:master Jun 22, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants