Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Zone form field to use groupedlist fancy select layout #42774

Merged
merged 9 commits into from
Mar 4, 2024

Conversation

cyrezdev
Copy link
Contributor

@cyrezdev cyrezdev commented Feb 7, 2024

Summary of Changes

Time Zone form field to use groupedlist fancy select layout.

This makes it easier to select the website or user time zone instead of scrolling through 420 time zones.

Testing Instructions

Install the patch and test Website Time Zone option (global config) as well as user Time Zone option in profile.

Actual result BEFORE applying this Pull Request

Capture d’écran 2024-02-07 à 16 19 40

Expected result AFTER applying this Pull Request

Capture d’écran 2024-02-07 à 16 20 45

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Feb 7, 2024

Please fix phpcs https://ci.joomla.org/joomla/joomla-cms/73346/1/8

@cyrezdev
Copy link
Contributor Author

cyrezdev commented Feb 7, 2024

Please fix phpcs https://ci.joomla.org/joomla/joomla-cms/73346/1/8

Thank you!
Oh yes... spaces... no tabs... :-D

@fgsw
Copy link

fgsw commented Feb 8, 2024

I have tested this item ✅ successfully on 6a0fea5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.

@Fedik Fedik added the Feature label Feb 8, 2024
@Quy
Copy link
Contributor

Quy commented Feb 8, 2024

Please rebase for v5.1 as this is not a bug. Thanks.

@cyrezdev
Copy link
Contributor Author

cyrezdev commented Feb 8, 2024

Please rebase for v5.1 as this is not a bug. Thanks.

Really?...

The first purpose was an improvement (not a new feature).
But, after comments from @laoneo and @rdeutz it appears i did it wrong. I redid it. And now it add a fix as well due to a choices.js issue: #42774 (comment)

If it's ok with my last update of this PR, i can rebase it if required. ;)

@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Feb 20, 2024
@tomsrocket
Copy link

I have tested this item ✅ successfully on 5b772fa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.

1 similar comment
@ChristineWk
Copy link

I have tested this item ✅ successfully on 5b772fa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.

@ChristineWk
Copy link

Tested in 5.1.0-alpha4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.

@richard67 richard67 removed the PBF Pizza, Bugs and Fun label Feb 24, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2024
@richard67 richard67 added the PBF Pizza, Bugs and Fun label Feb 24, 2024
@laoneo
Copy link
Member

laoneo commented Feb 26, 2024

As @Fedik mentioned already, please rebase this one to 5.1. I'm also not sure about the inline comment. Can the change be reverted when Choices-js/Choices#1110 is merged and added into Joomla?

@richard67 richard67 removed RTC This Pull Request is Ready To Commit Information Required PBF Pizza, Bugs and Fun labels Feb 26, 2024
@richard67
Copy link
Member

Back to pending due to requested rebase.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774.

@cyrezdev cyrezdev changed the base branch from 4.4-dev to 5.1-dev February 26, 2024 18:54
@cyrezdev
Copy link
Contributor Author

cyrezdev commented Feb 26, 2024

As @Fedik mentioned already, please rebase this one to 5.1. I'm also not sure about the inline comment. Can the change be reverted when Choices-js/Choices#1110 is merged and added into Joomla?

Just rebased.

About the fix, this one could be removed when choices.js with the fix for isolated options integrated.
It won't be an issue as the fix here create an empty group to be able to display isolated options (when mixed list of optgroup and option) to be diplayed in first position.
Only with Choices library updated that it will allow to use not-in-group options to be displayed at wanted places. For now, it's impossible.

So, yes, this change could be reverted when choices fixed! ;-)

@LadySolveig LadySolveig merged commit c754b8b into joomla:5.1-dev Mar 4, 2024
2 of 3 checks passed
@LadySolveig
Copy link
Contributor

Thank you for this nice improvement! @cyrezdev And also for testing @fgsw @ChristineWk

@cyrezdev
Copy link
Contributor Author

cyrezdev commented Mar 5, 2024

Thank all for testing and feedback! 👍

@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.