-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Time Zone form field to use groupedlist fancy select layout #42774
Conversation
Please fix phpcs https://ci.joomla.org/joomla/joomla-cms/73346/1/8 |
Thank you! |
I have tested this item ✅ successfully on 6a0fea5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774. |
Please rebase for v5.1 as this is not a bug. Thanks. |
Really?... The first purpose was an improvement (not a new feature). If it's ok with my last update of this PR, i can rebase it if required. ;) |
Co-authored-by: Quy <[email protected]>
I have tested this item ✅ successfully on 5b772fa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774. |
1 similar comment
I have tested this item ✅ successfully on 5b772fa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774. |
Tested in 5.1.0-alpha4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774. |
As @Fedik mentioned already, please rebase this one to 5.1. I'm also not sure about the inline comment. Can the change be reverted when Choices-js/Choices#1110 is merged and added into Joomla? |
Back to pending due to requested rebase. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42774. |
Just rebased. About the fix, this one could be removed when choices.js with the fix for isolated options integrated. So, yes, this change could be reverted when choices fixed! ;-) |
Thank you for this nice improvement! @cyrezdev And also for testing @fgsw @ChristineWk |
Thank all for testing and feedback! 👍 |
Summary of Changes
Time Zone form field to use groupedlist fancy select layout.
This makes it easier to select the website or user time zone instead of scrolling through 420 time zones.
Testing Instructions
Install the patch and test Website Time Zone option (global config) as well as user Time Zone option in profile.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed