Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documenter to 1.3 #253

Merged
merged 1 commit into from
Apr 7, 2024
Merged

Conversation

goerz
Copy link
Contributor

@goerz goerz commented Mar 22, 2024

This enables the automatic writing of an objects.inv inventory file (and also gives the documentation a slightly nicer UI).

I'd like to be able to use DocumenterInterLinks to link from my project to the documentation of CompomentArrays, and this update would make that easier. See also SciML/RecursiveArrayTools.jl#364, although here you were still using a pinned pre-1.0 version of Documenter. (Actually, so old that even DocumenterInventoryWritingBackport doesn't support it anymore.) I tried building locally, and everything seems to work fine with Documenter 1.3.

I didn't touch the CI still using Julia 1.6, although using a more recent version of Julia would probably be a good idea.

This enables the automatic writing of an `objects.inv` inventory
file (and also give the documentation a slightly nicer UI)
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.09%. Comparing base (44a9d4c) to head (d76d832).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #253   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files          25       25           
  Lines         772      772           
=======================================
  Hits          572      572           
  Misses        200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonniedie
Copy link
Owner

Looks good to me, thanks!

@jonniedie jonniedie merged commit e7f766e into jonniedie:main Apr 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants