Fix multi-symbol indexing when components are matrices

jonniedie · May 11, 2024 · 9f392b3 · 9f392b3
1 parent e7f766e
commit 9f392b3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/axis.jl b/src/axis.jl
@@ -173,7 +173,7 @@ function Base.getindex(ax::AbstractAxis, syms::Union{NTuple{N,Symbol}, <:Abstrac
     return ComponentIndex(vcat(inds...), new_ax)
 end
 
-_maybe_view_axis(inds, ax::Axis) = ViewAxis(inds, ax)
+_maybe_view_axis(inds, ax::AbstractAxis) = ViewAxis(inds, ax)
 _maybe_view_axis(inds, ::NullAxis) = inds[1]
 
 struct CombinedAxis{C,A} <: AbstractUnitRange{Int}

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -286,7 +286,10 @@ end
     # We had to revert this because there is no way to work around
     # OffsetArrays' type piracy without introducing type piracy
     # ourselves because `() isa Tuple{N, <:CombinedAxis} where {N}`
-    # @test reshape(a, axes(ca)...) isa Vector{Float64}
+    @test_broken reshape(a, axes(ca)...) isa Vector{Float64}
+
+    # Issue #265: Multi-symbol indexing with matrix components
+    @test ca2.c[[:a, :b]].b isa AbstractMatrix
 end
 
 @testset "Set" begin