Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental hack to unify mustache and mustache_template libraries #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xxgreg
Copy link

@xxgreg xxgreg commented Nov 2, 2020

Thanks for keeping the mustache/mustache_template packages going. I haven't had time to do any development on these for a while.

Here's a pull request which isn't intended for merging as-is, rather a proof of concept, to demonstrate an idea, and get feedback. (This is a 1hr hack, and I haven't even tried to run the code).

The idea is to provide a pluggable system for resolving values. And then to provide a separate dart file to import called 'mustache_with_mirrors.dart' which uses a mirrors resolver by default. The existing mustache_template code-path remains the same and does not import mirrors. Doing something like this would allow the same package to support both the mirrors, and non-mirrors approach.

I'm pretty sure there's a better way to do it this, but this was the first thing that came to mind.

Comments appreciated.

Cheers,
Greg.

@jonahwilliams
Copy link
Owner

Hey @xxgreg , sorry for the lack of response on my end. Github is a bit of a firehose for me and it seems this one slipped through the cracks. I will take a look this week

@jonahwilliams jonahwilliams self-requested a review June 27, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants