Use a registry for storing docker frontend image #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
force-pushed
the
registry
branch
30 times, most recently
from
37d1e9f
to
c733b08
Compare
lyrixx
force-pushed
the
registry
branch
2 times, most recently
from
0e8264b
to
a1501c8
Compare
lyrixx
commented
Jul 1, 2023
| } | ||
|
|
||
| function docker_compose_run( | ||
| string $runCommand, | ||
| Context $c = null, | ||
| string $service = 'builder', | ||
| string $user = 'app', |
There was a problem hiding this comment.
It's not possible to exec something with something else than app. Anyway, we never changed this value, right?
Comment on lines
+12
to
+15
| # cache_to: | ||
| # - "ghcr.io/jolicode/monologue/builder:${BUILDER_VERSION:-latest}" | ||
| # cache_from: | ||
| # - "ghcr.io/jolicode/monologue/builder:${BUILDER_VERSION:-latest}" |
There was a problem hiding this comment.
If we want, we can share the cache on the registry. Not sure it's useful tho
| @@ -29,7 +41,7 @@ services: | |||
| - "traefik.http.routers.${PROJECT_NAME}-frontend-unsecure.middlewares=redirect-to-https@file" | |||
|
|
|||
| postgres: | |||
| build: services/postgres | |||
| image: postgres:15.2 | |||
There was a problem hiding this comment.
Avoid pushing an extra image to the registry
There was a problem hiding this comment.
This file will update the linux user ID at runtime:
- if I publish an image, the image will contain my user id (usually 1000)
- Then if someone else (let's say GA) runs with another user id (let's say 1001), the permission will be wrong (host = 1001, container = 1000).
So this entry point will update the app user id in the container, to match the one on the host.
lyrixx
force-pushed
the
registry
branch
2 times, most recently
from
a9fc149
to
5e1167d
Compare
bastnic
reviewed
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.