feat(symfony): remove useless pass for property info, remove cache (#166

)

I remove the compiler pass for property info, i think it was useless.

I also removed the cache for property info, we don't need it and it was
causing DX issues when changing metadata of a class (as data was cached
and not correctly reload)

Last thing i used only our own services for property info, i don't want
that other configuration messing up with our way of configuring those
classes

CHANGELOG.md

@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Fixed
+- [GH#166](https://github.com/jolicode/automapper/pull/166) Remove cache for property info, use specific services instead
 
 ## [9.1.1] - 2024-06-19
 ### Fixed

src/Symfony/Bundle/AutoMapperBundle.php

@@ -5,7 +5,6 @@
 namespace AutoMapper\Symfony\Bundle;
 
 use AutoMapper\Symfony\Bundle\DependencyInjection\AutoMapperExtension;
-use AutoMapper\Symfony\Bundle\DependencyInjection\Compiler\PropertyInfoPass;
 use AutoMapper\Symfony\Bundle\DependencyInjection\Compiler\TransformerFactoryPass;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
@@ -17,7 +16,6 @@ public function build(ContainerBuilder $container): void
     {
         parent::build($container);
 
-        $container->addCompilerPass(new PropertyInfoPass());
         $container->addCompilerPass(new TransformerFactoryPass());
     }
 

src/Symfony/Bundle/DependencyInjection/AutoMapperExtension.php

@@ -25,6 +25,7 @@
 use Symfony\Component\DependencyInjection\Extension\Extension;
 use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
 use Symfony\Component\DependencyInjection\Reference;
+use Symfony\Component\PropertyInfo\Extractor\ReflectionExtractor;
 use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
 use Symfony\Component\Serializer\SerializerInterface;
 use Symfony\Component\Uid\AbstractUid;
@@ -53,6 +54,7 @@ public function load(array $configs, ContainerBuilder $container): void
         $loader->load('expression_language.php');
         $loader->load('generator.php');
         $loader->load('metadata.php');
+        $loader->load('property_info.php');
         $loader->load('provider.php');
         $loader->load('symfony.php');
         $loader->load('transformers.php');
@@ -67,6 +69,11 @@ public function load(array $configs, ContainerBuilder $container): void
             ->setArgument('$allowReadOnlyTargetToPopulate', $config['allow_readonly_target_to_populate'])
         ;
 
+        if ($config['map_private_properties']) {
+            $container->getDefinition('automapper.property_info.reflection_extractor')
+                ->replaceArgument('$accessFlags', ReflectionExtractor::ALLOW_PUBLIC | ReflectionExtractor::ALLOW_PRIVATE | ReflectionExtractor::ALLOW_PROTECTED);
+        }
+
         $container->setParameter('automapper.map_private_properties', $config['map_private_properties']);
 
         $container->registerForAutoconfiguration(PropertyTransformerInterface::class)->addTag('automapper.property_transformer');

src/Symfony/Bundle/Resources/config/property_info.php

@@ -0,0 +1,34 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use AutoMapper\Extractor\ReadWriteTypeExtractor;
+use Symfony\Component\PropertyInfo\Extractor\PhpStanExtractor;
+use Symfony\Component\PropertyInfo\Extractor\ReflectionExtractor;
+use Symfony\Component\PropertyInfo\PropertyInfoExtractor;
+
+return static function (ContainerConfigurator $container) {
+    $container
+        ->services()
+            ->set('automapper.property_info.reflection_extractor', ReflectionExtractor::class)
+                ->args([
+                    '$mutatorPrefixes' => null,
+                    '$accessorPrefixes' => null,
+                    '$arrayMutatorPrefixes' => null,
+                    '$enableConstructorExtraction' => true,
+                    '$accessFlags' => ReflectionExtractor::ALLOW_PUBLIC,
+                ])
+            ->set('automapper.property_info.read_write_type_extractor', ReadWriteTypeExtractor::class)
+            ->set('automapper.property_info.phpstan_extractor', PhpStanExtractor::class)
+            ->set('automapper.property_info', PropertyInfoExtractor::class)
+                ->args([
+                    [service('automapper.property_info.reflection_extractor')],
+                    [service('automapper.property_info.read_write_type_extractor'), service('automapper.property_info.phpstan_extractor'), service('automapper.property_info.reflection_extractor')],
+                    [service('automapper.property_info.reflection_extractor')],
+                    [service('automapper.property_info.reflection_extractor')],
+                    [service('automapper.property_info.reflection_extractor')],
+                ])
+    ;
+};