Support blank configuration when url is null or empty #201
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR was closed by mistake. Reopened it. |
jxltom
force-pushed
the
support-nullable-configurations
branch
from
143410a
to
75126a1
Compare
jxltom
force-pushed
the
support-nullable-configurations
branch
from
75126a1
to
bf1e8c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error will be raised if url is empty or null. This PR supports to return blank configuration directly if url is null or empty. This is very useful when users intend to fallback to emtpy configurations without raising errors, such as in unused environment settings in
django-configurations. Othewise, all envs should be properly set in each env configurations even they are not going to be used indjango-configurations