-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PMMP 3.19.0 #309
base: master
Are you sure you want to change the base?
Conversation
this doesnt add support for 3.19 |
I've tested it, it adds support for 3.19.0 |
but don't use PureEntitiesX with this fix or use my fix of PureEntitiesX too |
@@ -58,7 +60,7 @@ protected function sendSpawnPacket(Player $player): void { | |||
$pk2->uuid = UUID::fromRandom(); | |||
$pk2->username = $this->getDisplayName($player); | |||
$pk2->position = $this->asVector3()->add(0, static::HEIGHT); | |||
$pk2->item = ItemFactory::get(ItemIds::AIR); | |||
$pk2->item = ItemStackWrapper::legacy(Item::get(Item::AIR)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, changing ItemFactory and ItemIds to Item is an unrelated change. Please revert it. Also, remove the added import for pocketmine\item\Item
@@ -60,7 +59,7 @@ protected function sendSpawnPacket(Player $player): void { | |||
$pk2->uuid = UUID::fromRandom(); | |||
$pk2->username = $this->getDisplayName($player); | |||
$pk2->position = $this->asVector3()->add(0, static::HEIGHT); | |||
$pk2->item = ItemStackWrapper::legacy(Item::get(Item::AIR)); | |||
$pk2->item = ItemStackWrapper::legacy(Item::get(ItemIds::AIR)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also change Item::get back to ItemFactory::get
:) |
why nobody merges |
because nobody cares :( |
@@ -1,12 +1,13 @@ | |||
name: Slapper | |||
author: jojoe77777 | |||
version: 1.7.0 | |||
version: 1.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the previous version bump you made was never merged into master, I think there is no need for another one
@@ -1,11 +1,13 @@ | |||
name: Slapper | |||
author: jojoe77777 | |||
version: 1.6.1 | |||
version: 1.7.1 | |||
description: Slapper, the NPC plugin for PocketMine-MP | |||
main: slapper\Main | |||
api: 3.13.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to bump the minimum required API version to 3.14.0 since ItemStackWrapper::legacy
was added there: pmmp/PocketMine-MP@3.13.1...3.14.0#diff-68d4439663f67995bb26425e333d43bbce3d952bbc1df6f26dcdc1173bad458cR41
Because jojoe77777 doesn't care |
Fixed bugs in PMMP 3.19.0