9.3 Weather App Project #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angiepmunoz
reviewed
Jan 13, 2023
| //This removes the "no previous searches" text after you input a location | ||
| document.querySelector(".hide").setAttribute("style", "display: none"); | ||
|
|
||
| form.reset(); |
There was a problem hiding this comment.
It seems like resetting your form is the last thing you are doing but you should do it almost immediately after you grab the event value. (Id recommend in your fetch after calling createWeatherForecast() in getWeatherInfo())
| function extractUserLocation(url) { | ||
| const inputLocation = url.split(/[/?]/)[3].replace("%20", " "); | ||
| return inputLocation; | ||
| } |
There was a problem hiding this comment.
Looks like you don't have code for the temperature conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come to an impasse with the Previous Searches, if i had more time i can rewrite my entire code to then allow for easier functionality but due to time constraints, i think i may have to call it here and focus on the portfolio project.