Updated unloading of plugins with Deferred #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also wondering if there are any other obvious places we should add |
|
Superseded by #86 again. :) |
|
This bouncing back and forth thing is kinda fun @S0lll0s :P |
|
Closing this since I'm moving forward with #90 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@S0lll0s I made some changes and wanted to open a new pull request to see what you thought before I merged this. I tried to make it a little more linear as well. Let me know if you think I did something wrong or whether you think I could make it more readable. :) I'm starting to get the hang of Twisted after many hours of tweaking this code just right. :P
Blocking #58