Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update welcome.mdx #333

Open
wants to merge 18 commits into
base: stage
Choose a base branch
from
Open

Conversation

ghassen-fatnassi
Copy link

added myself :)

Copy link
Collaborator

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ghassen-fatnassi! We discussed on Discord about making stage branch the default so I guess this addition can already target it 😄

@ghassen-fatnassi
Copy link
Author

Thanks @ghassen-fatnassi! We discussed on Discord about making stage branch the default so I guess this addition can already target it 😄

this is my first time creating a pull request and i'm not very familiar what you just said :) can you please clarify , thanks!

@sergiopaniego
Copy link
Collaborator

Thanks @ghassen-fatnassi! We discussed on Discord about making stage branch the default so I guess this addition can already target it 😄

this is my first time creating a pull request and i'm not very familiar what you just said :) can you please clarify , thanks!

Sure!
You've created a PR from your forked repo that will be merged into the main branch of this repo. We talked on Discord about making the stage branch of this repo the default one, so any new PR should be merged into that branch instead of the main.

You can see this info in the upper part of this page:

image

To change the target branch, you can press the Edit button on the top-right and select the target branch (where it says main, it should be stage):

image

@ghassen-fatnassi ghassen-fatnassi changed the base branch from main to stage August 20, 2024 06:51
@ghassen-fatnassi
Copy link
Author

Thanks @ghassen-fatnassi! We discussed on Discord about making stage branch the default so I guess this addition can already target it 😄

this is my first time creating a pull request and i'm not very familiar what you just said :) can you please clarify , thanks!

Sure! You've created a PR from your forked repo that will be merged into the main branch of this repo. We talked on Discord about making the stage branch of this repo the default one, so any new PR should be merged into that branch instead of the main.

You can see this info in the upper part of this page:

image To change the target branch, you can press the `Edit` button on the top-right and select the target branch (where it says `main`, it should be `stage`): image

done , thanks a lot

@johko
Copy link
Owner

johko commented Aug 20, 2024

Hey @ghassen-fatnassi , sorry for the confusion with the branches and thanks for changing to the staging branch. Now it shows some conflicting files, because probably your branch is not completely up-to-date with our stage branch.

I'm also not a git expert but I think you can try to run git rebase upstream/stage in a terminal when inside your project folder and should be able to resolve the conflicts locally. Then commit and push the result
If you have more questions or problems with that, let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants