Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit 8 fixes - latex stuff and broken link minor corrections #285

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

psetinek
Copy link
Contributor

Some fixes for chapter 8:

  • mainly latex related where I changed $...$ to \( ... \).
  • fixed Rotation matrix around z-axis in the linear algebra mdx.
  • fixed path to image for NeRF encodings in nerf mdx.

Copy link
Collaborator

@bellabf bellabf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

For some housekeeping, the z-axis rotation fixes the issue #283

@sergiopaniego
Copy link
Collaborator

Could it be better if there was a space between the Latex text and the rest?
Like in here:

image

Reference: https://moon-ci-docs.huggingface.co/docs/computer-vision-course/pr_285/unit8/3d-vision/nvs

@bellabf
Copy link
Collaborator

bellabf commented Apr 29, 2024

Could it be better if there was a space between the Latex text and the rest? Like in here:

image

Reference: https://moon-ci-docs.huggingface.co/docs/computer-vision-course/pr_285/unit8/3d-vision/nvs

I actually do not really know how to fix this. There is a similar problem with image.mdx in unit 1. I found digging some other PR that it was mentioned #228 (comment) that the problem was from the docbuilder. Since multiple units have this problem, it would be better to fix the docbuilder.

Maybe @merveenoyan or @johko know more about this?

@merveenoyan
Copy link
Collaborator

merveenoyan commented Apr 30, 2024

@sergiopaniego @bellabf unfortunately this is an error on docbuilder's side

@merveenoyan merveenoyan merged commit 2259cdc into johko:main Apr 30, 2024
2 checks passed
@merveenoyan
Copy link
Collaborator

@psetinek would you be down to maybe write HTML to center images and the text underneath?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants