Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix math typos #278

Merged
merged 4 commits into from
May 2, 2024
Merged

fix math typos #278

merged 4 commits into from
May 2, 2024

Conversation

omkar-12bits
Copy link
Contributor

@omkar-12bits omkar-12bits commented Apr 27, 2024

  • fixed calculation of parameter multiplication typo which was replacing /* which was rendering italic font in calculation.
  • fixed typos of math formatter from (\\ 5 \times 5 \\) to \( 5 \times 5 \).
  • Might wanna consider Auxiliary Classifiers section \\( 5 \times 5 \\) renders bold highlighted 5x5 in course but in markdown preview \( 5 \times 5 \) , shows bold highlighted text, should i keep this format or should i stick to working format of blog on HF which is \\( 5 \times 5 \\).

@merveenoyan
Copy link
Collaborator

@omkar-12bits thanks for opening the PR, you can check out how it renders, some of it didn't render: https://moon-ci-docs.huggingface.co/docs/computer-vision-course/pr_278/en/unit2/cnns/googlenet

@omkar-12bits
Copy link
Contributor Author

it works now.
seems everyone is having issue of latex rendering without space so that may be some another day ?

@ATaylorAerospace ATaylorAerospace self-requested a review May 1, 2024 16:29
Copy link
Collaborator

@ATaylorAerospace ATaylorAerospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for Updating. It does appear to render correctly now but lets let @merveenoyan also take a quick look to confirm

@merveenoyan merveenoyan merged commit 6a8a91c into johko:main May 2, 2024
2 checks passed
@omkar-12bits omkar-12bits deleted the googlenet branch May 3, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants