Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nits in Unit 1 #272

Merged
merged 9 commits into from
Apr 30, 2024
Merged

Nits in Unit 1 #272

merged 9 commits into from
Apr 30, 2024

Conversation

bellabf
Copy link
Collaborator

@bellabf bellabf commented Apr 26, 2024

Hi everyone,

This PR is to fix some of the nits in unit after its reordering.
There are some latex that need fixing. but I am not sure how to fix it yet. I will do another PR for that one once I figure it out.
If I manage, I will try to open PR same for the other units.

Thanks again!

Copy link
Collaborator

@mmhamdy mmhamdy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀Nice catch for the updated chapter references. Adding the titles also avoids possible future confusion.

Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! small comment otherwise looks good

@@ -1,6 +1,6 @@
# Feature Description

Features are attributes of the instances learnt by the model to be later used to recognize new instances.
Features are attributes of the instances learned by the model to be later used to recognize new instances.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Features are attributes of the instances learned by the model to be later used to recognize new instances.
Features are attributes of the instances learnt by the model to be later used to recognize new instances.

I think this is proper use

Copy link
Collaborator

@ATaylorAerospace ATaylorAerospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ATaylorAerospace ATaylorAerospace merged commit e03f0d4 into johko:main Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants