Reviewed general punctuation and fixed some broken links #251

sergiopaniego · 2024-04-15T16:03:22Z

In this PR I've:

Reviewed the general punctuation of the units and updated it.
Fixed some links that appeared broken.

I've used https://moon-ci-docs.huggingface.co/docs/computer-vision-course/pr_246/en/Unit%200%20-%20Welcome/welcome as a source to find the issues.

Let me know if the course is updated elsewhere and I'll update it accordingly.
This PR may cause merge issues with #250, so I could update it once the former is merged

merveenoyan

We do not have dots on headings, resources, clauses (that aren't sentences), end of parenthesis that already have dots
Also if you have time and if you feel like it, you can fix broke image links (I think there's a few in chapter 9)

sergiopaniego · 2024-04-23T07:57:11Z

Thanks for the feedback @merveenoyan! Would you like me to make modifications regarding the punctuation?
I'll review Chapter 9 for broken image links.
For now, I've merged the updated main branch 😄

sergiopaniego · 2024-04-23T13:39:29Z

chapters/en/Unit 9 - Model Optimization/intro_to_model_optimization.mdx

@@ -16,12 +16,12 @@ As we already know, optimizing the model is important in before the deployment s
 There are several techniques in the model optimization, which will be explained in the next section. However, this section will briefly describe several types:
 1. Pruning: Pruning is the process of eliminating redundant or unimportant connections in the model. This aims to reduce model size and complexity.

-![Pruning](https://huggingface.co/datasets/hf-vision/course-assets/raw/main/pruning.png)
+![Pruning](https://huggingface.co/datasets/hf-vision/course-assets/resolve/main/pruning.png)


Can we consider the links in Unit 9 fixed in this way?

sergiopaniego · 2024-04-23T13:40:20Z

chapters/en/Unit 8 - 3D Vision, Scene Rendering and Reconstruction/nerf.mdx

@@ -144,7 +144,7 @@ visualize_grid(grid, encoded_grid, resolution)

 The output should look something like the image below:

-![encoding](https://huggingface.co/datasets/hf-vision/course-assets/blob/main/nerf_encodings.png)
+![encoding](https://huggingface.co/datasets/hf-vision/course-assets/resolve/main/nerf_encodings.png)


This Unit image link is also updated

sergiopaniego · 2024-04-23T13:41:46Z

chapters/en/Unit 2 - Convolutional Neural Networks/introduction.mdx

@@ -70,7 +70,7 @@ The feature map will be the same size as the original data. The result of the co
 If we keep applying the convolution, we get the following feature map.

 <div class="flex justify-center">
-    <img src="https://huggingface.co/datasets/hf-vision/course-assets/resolve/main/CNNs/2d-feature_map.png" alt="2D Feature Map">
+    <img src="https://huggingface.co/datasets/hf-vision/course-assets/resolve/main/CNNs/2d_feature_map.png" alt="2D Feature Map">


Image broken link updated here

sergiopaniego · 2024-04-23T13:49:03Z

I've indicated where the update links are located.
I could even generate a separate PR just with the broken links if that's easier for merging 😃

…into main

merveenoyan

Thanks a lot! helps greatly :)

merveenoyan · 2024-04-25T21:56:21Z

chapters/en/unit1/image_and_imaging/examples-preprocess.mdx

- Statistical
- Geometrical
- Mathematical
+- Logical.


these aren't full sentences so there's no need

merveenoyan · 2024-04-25T21:56:45Z

chapters/en/unit10/blenderProc.mdx

- [User Manual](https://docs.blender.org/manual/en/latest/0)
- [Awesome-blender -- Extensive list of resources](https://awesome-blender.netlify.app)
- [Blender Youtube Channel](https://www.youtube.com/@BlenderOfficial)
+- [User Manual](https://docs.blender.org/manual/en/latest/0).


these aren't sentences so no need

merveenoyan · 2024-04-25T21:56:48Z

chapters/en/unit10/blenderProc.mdx

- [Developing digital twins of multi-camera metrology systems in Blender](https://iopscience.iop.org/article/10.1088/1361-6501/acc59e/pdf_)
- [Generate Depth and Normal Maps with Blender](https://www.saifkhichi.com/blog/blender-depth-map-surface-normals)
- [Object detection with synthetic training data](https://medium.com/rowden/object-detection-with-synthetic-training-data-f6735a5a34bc)
+- [Developing digital twins of multi-camera metrology systems in Blender](https://iopscience.iop.org/article/10.1088/1361-6501/acc59e/pdf_).


these aren't sentences so no need

merveenoyan · 2024-04-25T21:57:12Z

chapters/en/unit10/point_clouds.mdx

@@ -45,21 +45,21 @@ Now, first we need to understand the formats in which these point clouds are sto
 **Why?**

 - `point-cloud-utils` supports reading common mesh formats (PLY, STL, OFF, OBJ, 3DS, VRML 2.0, X3D, COLLADA).
- If it can be imported into [MeshLab](https://github.com/cnr-isti-vclab/meshlab), we can read it! (from their readme)
+- If it can be imported into [MeshLab](https://github.com/cnr-isti-vclab/meshlab), we can read it! (from their readme).


there's already exclamation mark here

merveenoyan · 2024-04-25T21:57:20Z

chapters/en/unit10/synthetic-lung-images.mdx

-  - Batch Normalization layer
-  - ReLU activation
- Conv2D layer with Tanh activation
+  - Conv2D layer.


these aren't sentences so no need

chapters/en/unit5/generative-models/gans-vaes/stylegan.mdx

merveenoyan · 2024-04-25T22:00:04Z

chapters/en/unit5/generative-models/gans-vaes/stylegan.mdx

-2. AdaIN (Adaptive Instance Normalisation)
-3. Concatenation of Noise vector
+Diagram (b) is the proposed StyleGAN architecture. It has the following main components:
+1. A mapping network.


these aren't sentences so no need

merveenoyan · 2024-04-25T22:00:18Z

chapters/en/unit8/3d_measurements_stereo_vision.mdx

 ![Rectified Left Image](https://huggingface.co/datasets/hf-vision/course-assets/resolve/main/3d_stereo_vision_images/rectified_left_frame.jpg?download=true)

-Rectified Right Image 
+Rectified Right Image. 


these aren't sentences so no need

merveenoyan · 2024-04-25T22:00:52Z

chapters/en/unit9/tools_and_frameworks.mdx

 - Write an application once, deploy it anywhere on your preferred device, language and OS.
- has minimal external dependencies 
- Reduces first-inference latency by using the CPU for initial inference and then switching to another device once the model has been compiled and loaded to memory
+- has minimal external dependencies.


these are subsentences in form of lists so no need

merveenoyan · 2024-04-25T22:01:01Z

chapters/en/unit9/tools_and_frameworks.mdx


 ## EdgeTPU

 ### Overview

 Edge TPU is Google’s purpose-built ASIC designed to run AI at the edge. It delivers high performance in a small physical and power footprint, enabling the deployment of high-accuracy AI at the edge.
 The benefits of using EdgeTPU includes:
- Complements Cloud TPU and Google Cloud services to provide an end-to-end, cloud-to-edge, hardware + software infrastructure for AI-based solutions deployment
- High performance in a small physical and power footprint
+- Complements Cloud TPU and Google Cloud services to provide an end-to-end, cloud-to-edge, hardware + software infrastructure for AI-based solutions deployment.


these are subsentences

merveenoyan · 2024-04-25T22:01:57Z

@sergiopaniego given the amount of fixes I think you should add your name to credits

Co-authored-by: Merve Noyan <[email protected]>

sergiopaniego · 2024-04-26T08:35:14Z

I've updated the files with all the suggestions, accepted your commits, and restored a broken link to a chapter.
Please let me know if there's anything else that needs attention!

@sergiopaniego given the amount of fixes I think you should add your name to credits

How should I add myself @merveenoyan?

Thanks for the in-depth review!

merveenoyan

Thanks! be mindful that we are looking for atomic PRs otherwise it will take a long time to merge changes

chapters/en/unit0/welcome/welcome.mdx

chapters/en/unit8/3d_measurements_stereo_vision.mdx

chapters/en/unit8/introduction/brief_history.mdx

merveenoyan · 2024-04-30T12:54:06Z

@sergiopaniego when we make comments we would like to make them general, please reflect them across the text or I have to fix them one by one which takes a lot of time

merveenoyan · 2024-04-30T12:55:45Z

@sergiopaniego you can give yourself credit on credits section in 0th chapter

Co-authored-by: Merve Noyan <[email protected]>

…ion.mdx Co-authored-by: Merve Noyan <[email protected]>

…ffusion.mdx Co-authored-by: Merve Noyan <[email protected]>

Co-authored-by: Merve Noyan <[email protected]>

…ical-issues.mdx Co-authored-by: Merve Noyan <[email protected]>

Co-authored-by: Merve Noyan <[email protected]>

sergiopaniego · 2024-05-15T01:19:40Z

@sergiopaniego when we make comments we would like to make them general, please reflect them across the text or I have to fix them one by one which takes a lot of time

Thank you for all the suggestions and your thorough review. Apologies for my delayed responses (been busy with work and a conference).

I've accepted all your suggestions. I'll conduct a detailed review of the entire PR to ensure that all the suggestions are reflected.

…on-course into main

sergiopaniego · 2024-05-16T00:45:50Z

Hi @merveenoyan 😄 I've conducted the review and the PR is now ready to be checked.

I've removed some punctuation thanks to your suggestions and updated some broken links that I've found while reviewing (1c20a24)

johko

a very late review, but LGTM 👍

will merge it (finally)

sergiopaniego · 2024-07-01T07:40:56Z

Thanks @johko! 😄

sergiopaniego added 2 commits April 12, 2024 17:26

Punctuation updated and broken image link restored

227e279

Review punctuation and fixed some broken links

87a9456

sergiopaniego requested a review from merveenoyan as a code owner April 15, 2024 16:03

merveenoyan reviewed Apr 22, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into main

a7bb7db

sergiopaniego commented Apr 23, 2024

View reviewed changes

Restored HTTP image link

aee83e5

Merge branch 'main' of https://github.com/johko/computer-vision-course …

5b0b687

…into main

sergiopaniego mentioned this pull request Apr 25, 2024

Resolve Image Not Loaded in Chapter 9 #261

Merged

merveenoyan reviewed Apr 25, 2024

View reviewed changes

sergiopaniego and others added 4 commits April 26, 2024 09:53

Merge remote-tracking branch 'upstream/main'

fdc9f2f

Update chapters/en/unit5/generative-models/gans-vaes/stylegan.mdx

7efc70c

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit5/generative-models/gans-vaes/stylegan.mdx

e84231b

Co-authored-by: Merve Noyan <[email protected]>

Updated suggestions and broken link

5a071d4

Merge remote-tracking branch 'upstream/main'

63c5921

merveenoyan approved these changes Apr 30, 2024

View reviewed changes

sergiopaniego and others added 6 commits May 15, 2024 09:38

Merge remote-tracking branch 'remote_repo/main' into main

9f775d5

Update chapters/en/unit0/welcome/welcome.mdx

018cef9

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit0/welcome/welcome.mdx

2e33328

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit0/welcome/welcome.mdx

7516792

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit0/welcome/welcome.mdx

b6be1d8

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit0/welcome/welcome.mdx

3953ca7

Co-authored-by: Merve Noyan <[email protected]>

sergiopaniego and others added 15 commits May 15, 2024 10:04

Update chapters/en/unit5/generative-models/diffusion-models/introduct…

a23ecc0

…ion.mdx Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit5/generative-models/diffusion-models/introduct…

56ad356

…ion.mdx Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit5/generative-models/diffusion-models/stable-di…

c8e9a55

…ffusion.mdx Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit5/generative-models/diffusion-models/stable-di…

279c808

…ffusion.mdx Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit5/generative-models/introduction/introduction.mdx

9e4eb7b

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit5/generative-models/introduction/introduction.mdx

034d3fb

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit5/generative-models/introduction/introduction.mdx

2937fbc

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit5/generative-models/practical-applications/eth…

df87c30

…ical-issues.mdx Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit5/generative-models/practical-applications/eth…

c134cb8

…ical-issues.mdx Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit5/generative-models/practical-applications/eth…

8d927af

…ical-issues.mdx Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit8/3d_measurements_stereo_vision.mdx

16a17a0

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit8/3d_measurements_stereo_vision.mdx

f74dce2

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit8/3d_measurements_stereo_vision.mdx

99450b6

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit8/introduction/brief_history.mdx

1c55514

Co-authored-by: Merve Noyan <[email protected]>

Update chapters/en/unit8/introduction/brief_history.mdx

39299fa

Co-authored-by: Merve Noyan <[email protected]>

sergiopaniego added 9 commits May 15, 2024 13:13

Modified pip install spacing

7e8bbc0

Merge branch 'main' of https://github.com/sergiopaniego/computer-visi…

c122f3e

…on-course into main

Extended spacing update of pip install instructions across units

71233b6

Removed punctuations in table following standards

6107b34

Removed unneeded new lines

c652dfb

Updated some broken links pointing to the course

1c20a24

Added new line to separate sentences

a39c49d

Removed unneeded puntuaction

3f73731

Removed unneeded punctuation

1c69233

sergiopaniego mentioned this pull request May 29, 2024

Added credits as a reviewer #310

Merged

johko approved these changes Jun 28, 2024

View reviewed changes

johko merged commit f532359 into johko:main Jul 17, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reviewed general punctuation and fixed some broken links #251

Reviewed general punctuation and fixed some broken links #251

sergiopaniego commented Apr 15, 2024

merveenoyan left a comment

sergiopaniego commented Apr 23, 2024

sergiopaniego Apr 23, 2024

sergiopaniego Apr 23, 2024

sergiopaniego Apr 23, 2024

sergiopaniego commented Apr 23, 2024

merveenoyan left a comment

merveenoyan Apr 25, 2024

merveenoyan Apr 25, 2024

merveenoyan Apr 25, 2024

merveenoyan Apr 25, 2024

merveenoyan Apr 25, 2024

merveenoyan Apr 25, 2024

merveenoyan Apr 25, 2024

merveenoyan Apr 25, 2024

merveenoyan Apr 25, 2024

merveenoyan commented Apr 25, 2024

sergiopaniego commented Apr 26, 2024

merveenoyan left a comment

merveenoyan commented Apr 30, 2024

merveenoyan commented Apr 30, 2024

sergiopaniego commented May 15, 2024

sergiopaniego commented May 16, 2024

johko left a comment

sergiopaniego commented Jul 1, 2024

Reviewed general punctuation and fixed some broken links #251

Reviewed general punctuation and fixed some broken links #251

Conversation

sergiopaniego commented Apr 15, 2024

merveenoyan left a comment

Choose a reason for hiding this comment

sergiopaniego commented Apr 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergiopaniego commented Apr 23, 2024

merveenoyan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

merveenoyan commented Apr 25, 2024

sergiopaniego commented Apr 26, 2024

merveenoyan left a comment

Choose a reason for hiding this comment

merveenoyan commented Apr 30, 2024

merveenoyan commented Apr 30, 2024

sergiopaniego commented May 15, 2024

sergiopaniego commented May 16, 2024

johko left a comment

Choose a reason for hiding this comment

sergiopaniego commented Jul 1, 2024