-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit 11 : Zero-Shot Learning draft #200
Conversation
Co-authored-by: Mohammed Hamdy <[email protected]>
Co-authored-by: Mohammed Hamdy <[email protected]>
Co-authored-by: Mohammed Hamdy <[email protected]>
Co-authored-by: Mohammed Hamdy <[email protected]>
Co-authored-by: Mohammed Hamdy <[email protected]>
Co-authored-by: Mohammed Hamdy <[email protected]>
Co-authored-by: Mohammed Hamdy <[email protected]>
Co-authored-by: Mohammed Hamdy <[email protected]>
Co-authored-by: Mohammed Hamdy <[email protected]>
Co-authored-by: Mohammed Hamdy <[email protected]>
Zero shot cv 2mdx
I enjoyed reading this. Left some suggestion on how to make the transition between sections easier :) |
Thank you @bellabf for reviewing, may I learn a bit more on the suggestions? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this! Mostly did nitpicking :)
Co-authored-by: Merve Noyan <[email protected]>
Co-authored-by: Merve Noyan <[email protected]>
Co-authored-by: Merve Noyan <[email protected]>
Co-authored-by: Merve Noyan <[email protected]>
Thank you for the suggestion! I added a section to introduce the relationship between ZSL vs CLIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🤗!
All my suggestions are removing some empty lines and are all for formatting purposes.
Otherwise, LGTM :).
Co-authored-by: Isabella Bicalho Frazeto <[email protected]>
Co-authored-by: Isabella Bicalho Frazeto <[email protected]>
Co-authored-by: Isabella Bicalho Frazeto <[email protected]>
Co-authored-by: Isabella Bicalho Frazeto <[email protected]>
Co-authored-by: Isabella Bicalho Frazeto <[email protected]>
Co-authored-by: Isabella Bicalho Frazeto <[email protected]>
@albertkao227 if you could commit changes and format the pages using styling we can merge this |
Co-authored-by: Merve Noyan <[email protected]>
Co-authored-by: Merve Noyan <[email protected]>
Co-authored-by: Merve Noyan <[email protected]>
Co-authored-by: Merve Noyan <[email protected]>
Thank you @merveenoyan! I committed the changes, may I learn a bit more the page format styling guidelines? Maybe it is obvious but I somehow missed it. |
Apologies, if you are referring to https://github.com/johko/computer-vision-course?tab=readme-ov-file#-content-guidelines and _toctree.yml then I think I understand. Thank you! |
Looks good to me |
@albertkao227 seems like review is done, you can merge the patch. |
@albertkao227 since your branch is behind the main, you don't have the latest toctree, and thus the checks are red. Can you update your main branch? Easiest way to do so is to click "Sync fork" below. After that is done, you should add your chapter to toctree and the check will be green. Thank you! |
Thanks @merveenoyan Got it. Thanks for the explanation. |
Thank you much @merveenoyan and @ratan. The checks are green and I believe it is ready to be merged. |
No description provided.