Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit 11 : Zero-Shot Learning draft #200

Merged
merged 55 commits into from
Mar 1, 2024
Merged

Unit 11 : Zero-Shot Learning draft #200

merged 55 commits into from
Mar 1, 2024

Conversation

albertkao227
Copy link
Contributor

No description provided.

albertkao227 and others added 18 commits November 25, 2023 23:51
@mmhamdy mmhamdy added the Chapter Content Discuss and track the content of a chapter label Feb 4, 2024
@bellabf
Copy link
Collaborator

bellabf commented Feb 6, 2024

I enjoyed reading this. Left some suggestion on how to make the transition between sections easier :)

@albertkao227
Copy link
Contributor Author

albertkao227 commented Feb 6, 2024

I enjoyed reading this. Left some suggestion on how to make the transition between sections easier :)

Thank you @bellabf for reviewing, may I learn a bit more on the suggestions? :)

Copy link
Collaborator

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this! Mostly did nitpicking :)

chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
@albertkao227
Copy link
Contributor Author

Quite informative, I never actually knew there are so many fine differences 👍

What I'm missing a bit is the direct connection to Vision Models. Maybe you can name some popular Zero-shot models (like e.g. CLIP) and just add a bit more of an practical aspect to the part. So people who think "Hey, that is my use case" already get an idea what kind of models to look into.

But really nice work on the datasets as well 🤗

Thank you for the suggestion! I added a section to introduce the relationship between ZSL vs CLIP.

Copy link
Owner

@johko johko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@bellabf bellabf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🤗!

All my suggestions are removing some empty lines and are all for formatting purposes.
Otherwise, LGTM :).

chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
chapters/en/Unit 11 - Zero Shot Computer Vision/2.mdx Outdated Show resolved Hide resolved
@merveenoyan
Copy link
Collaborator

@albertkao227 if you could commit changes and format the pages using styling we can merge this

@albertkao227
Copy link
Contributor Author

@albertkao227 if you could commit changes and format the pages using styling we can merge this

Thank you @merveenoyan! I committed the changes, may I learn a bit more the page format styling guidelines? Maybe it is obvious but I somehow missed it.

@albertkao227
Copy link
Contributor Author

albertkao227 commented Feb 24, 2024

@albertkao227 if you could commit changes and format the pages using styling we can merge this

Thank you @merveenoyan! I committed the changes, may I learn a bit more the page format styling guidelines? Maybe it is obvious but I somehow missed it.

Apologies, if you are referring to https://github.com/johko/computer-vision-course?tab=readme-ov-file#-content-guidelines and _toctree.yml then I think I understand. Thank you!

@ratan
Copy link
Collaborator

ratan commented Feb 26, 2024

Looks good to me

@ratan
Copy link
Collaborator

ratan commented Feb 28, 2024

@albertkao227 seems like review is done, you can merge the patch.

@merveenoyan
Copy link
Collaborator

@albertkao227 since your branch is behind the main, you don't have the latest toctree, and thus the checks are red. Can you update your main branch? Easiest way to do so is to click "Sync fork" below.
Screenshot 2024-02-29 at 12 02 26

After that is done, you should add your chapter to toctree and the check will be green. Thank you!
@ratan we should strive to not merge until all checks are green otherwise the forks syncing to the main branch will all be red and CI will be broken.

@ratan
Copy link
Collaborator

ratan commented Feb 29, 2024

Thanks @merveenoyan Got it. Thanks for the explanation.

@albertkao227
Copy link
Contributor Author

@albertkao227 since your branch is behind the main, you don't have the latest toctree, and thus the checks are red. Can you update your main branch? Easiest way to do so is to click "Sync fork" below. Screenshot 2024-02-29 at 12 02 26

After that is done, you should add your chapter to toctree and the check will be green. Thank you! @ratan we should strive to not merge until all checks are green otherwise the forks syncing to the main branch will all be red and CI will be broken.

Thank you much @merveenoyan and @ratan. The checks are green and I believe it is ready to be merged.

@merveenoyan merveenoyan merged commit 32138ba into johko:main Mar 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chapter Content Discuss and track the content of a chapter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants