runat-1128988: Sync helpers.js with Firefox

Someone had added an assert.ok, and we protect ourselves against null DOM nodes in checking test output Signed-off-by: Joe Walker <[email protected]>
joewalker · Mar 12, 2015 · 271e262 · 271e262 · bgrins · Mar 13, 2015
1 parent d62af41
commit 271e262
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/gcli/test/helpers.js b/lib/gcli/test/helpers.js
@@ -578,7 +578,7 @@ helpers._exec = function(options, name, expected) {
       }
       else {
         convertPromise = output.convert('dom', context).then(function(node) {
-          return node.textContent.trim();
+          return (node == null) ? '' : node.textContent.trim();
         });
       }
 
@@ -791,6 +791,10 @@ helpers.audit = function(options, audits) {
             'due to ' + audit.skipRemainingIf.name :
             '';
         assert.log('Skipped ' + name + ' ' + skipReason);
+
+        // Tests need at least one pass, fail or todo. Create a dummy pass
+        assert.ok(true, 'Each test requires at least one pass, fail or todo');
+
         return Promise.resolve(undefined);
       }
     }