runat-1128988: Add event batching to commands-changed

We don't want to light up the remote interface 10x for every module, so this adds holdFire/resumeFire to addItemsByModule and friends. Signed-off-by: Joe Walker <[email protected]>
joewalker · Mar 19, 2015 · 1a76df2 · bgrins · Mar 19, 2015 · joewalker
1 parent 879c05f
commit 1a76df2
Showing 1 changed file with 25 additions and 2 deletions.
diff --git a/lib/gcli/system.js b/lib/gcli/system.js
@@ -149,7 +149,14 @@ exports.createSystem = function(options) {
     },
 
     addItemsByModule: function(names, options) {
+      var promises = [];
+
       options = options || {};
+      if (!options.delayedLoad) {
+        // We could be about to add many commands, just report the change once
+        this.commands.onCommandsChange.holdFire();
+      }
+
       if (typeof names === 'string') {
         names = [ names ];
       }
@@ -165,20 +172,34 @@ exports.createSystem = function(options) {
           pendingChanges = true;
         }
         else {
-          loadModule(name).catch(console.error);
+          promises.push(loadModule(name).catch(console.error));
         }
       });
+
+      if (options.delayedLoad) {
+        return Promise.resolve();
+      }
+      else {
+        return Promise.all(promises).then(function() {
+          this.commands.onCommandsChange.resumeFire();
+        }.bind(this));
+      }
     },
 
     removeItemsByModule: function(name) {
+      this.commands.onCommandsChange.holdFire();
+
       delete loadableModules[name];
       unloadModule(name);
+
+      this.commands.onCommandsChange.resumeFire();
     },
 
     load: function() {
       if (!pendingChanges) {
         return Promise.resolve();
       }
+      this.commands.onCommandsChange.holdFire();
 
       // clone loadedModules, so we can remove what is left at the end
       var modules = Object.keys(loadedModules).map(function(name) {
@@ -193,7 +214,9 @@ exports.createSystem = function(options) {
       Object.keys(modules).forEach(unloadModule);
       pendingChanges = false;
 
-      return Promise.all(promises);
+      return Promise.all(promises).then(function() {
+        this.commands.onCommandsChange.resumeFire();
+      }.bind(this));
     },
 
     toString: function() {