Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gosrc2cpg] Fixed an issue with skipping the statement before the if condition #5046

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

ch0a3
Copy link
Contributor

@ch0a3 ch0a3 commented Oct 31, 2024

I fix the issue seems like [gosrc2cpg] #4994
when I handle the code like:
if a := 1 (a < b)
in results of Json, the code a := 1 was put in init block, and the method skip this block.

Resolves #4994

@ch0a3 ch0a3 changed the title Fixed an issue with skipping the statement before the if condition [gosrc2cpg]Fixed an issue with skipping the statement before the if condition Oct 31, 2024
@DavidBakerEffendi DavidBakerEffendi self-assigned this Nov 2, 2024
@DavidBakerEffendi DavidBakerEffendi added the go Relates to gosrc2cpg label Nov 2, 2024
@DavidBakerEffendi
Copy link
Collaborator

Wrt formatting, run sbt scalafmt Test/scalafmt

@DavidBakerEffendi DavidBakerEffendi removed their assignment Nov 3, 2024
@DavidBakerEffendi
Copy link
Collaborator

Thanks for the fix!

@DavidBakerEffendi DavidBakerEffendi changed the title [gosrc2cpg]Fixed an issue with skipping the statement before the if condition [gosrc2cpg] Fixed an issue with skipping the statement before the if condition Nov 3, 2024
@DavidBakerEffendi DavidBakerEffendi merged commit eed2101 into joernio:master Nov 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Relates to gosrc2cpg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gosrc2cpg] Missing function calls inside if statement
2 participants