Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javasrc] keepTypeArguments Flag #4502

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

DavidBakerEffendi
Copy link
Collaborator

The desire for type arguments to be persisted in type nodes and properties has been around for a while.

This PR adds a hidden, off-by-default flag, keep-type-arguments, signals to the TypeInfoCalculator to build the full name with the full names of the type arguments.

Resolves #4488

The desire for type arguments to be persisted in type nodes and properties has been around for a while.

This PR adds a hidden, off-by-default flag, `keep-type-arguments`, signals to the `TypeInfoCalculator` to build the full name with the full names of the type arguments.

Resolves #4488
@DavidBakerEffendi DavidBakerEffendi merged commit 1f66f7d into master Apr 29, 2024
5 checks passed
@DavidBakerEffendi DavidBakerEffendi deleted the dave/javasrc/type-arg-flag branch April 29, 2024 14:10
DavidBakerEffendi added a commit that referenced this pull request May 7, 2024
* Similar to #4502, but for Kotlin.
* Made `TypeRenderer` an object for easier global setting of `keepTypeArgument`
* Improved null safety of `expr.getCalleeExpression` under `AstForExpressionsCreator.astsForNonCtorCall`

Resolves #4513
DavidBakerEffendi added a commit that referenced this pull request May 7, 2024
* Similar to #4502, but for Kotlin.
* Made `TypeRenderer` an object for easier global setting of `keepTypeArgument`
* Improved null safety of `expr.getCalleeExpression` under `AstForExpressionsCreator.astsForNonCtorCall`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Relates to javasrc2cpg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JavaSrc2Cpg] - Missing type information, in case of templated object
2 participants