Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify pynbody installation in tests again #619

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

jobovy
Copy link
Owner

@jobovy jobovy commented Dec 21, 2023

Now that the offending Python 3.8 versions were yanked from PyPI, so just pip installing pynbody again installs a Python 3.8-compatible version.

@jobovy jobovy added this to the v1.10 milestone Dec 21, 2023
@jobovy jobovy self-assigned this Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7d38e4) 98.95% compared to head (7b449d2) 99.91%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #619      +/-   ##
==========================================
+ Coverage   98.95%   99.91%   +0.96%     
==========================================
  Files         198      198              
  Lines       29459    29175     -284     
==========================================
  Hits        29151    29151              
+ Misses        308       24     -284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobovy jobovy merged commit 8e03145 into main Dec 21, 2023
88 checks passed
@jobovy jobovy deleted the pynbody-rmpy38-special-handling branch December 21, 2023 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant