test: define default clang args for testing #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For starters, define the language stardard to use. Use c17 and c++17, fairly arbitrarily. Tests can override this. We can remove the std option from template.yaml. This is a bit more convoluted than should be necessary, for a few reasons: - Extension tests use the directive options from directive string. For that, the defaults should be specified in conf.py, but hawkmoth_clang is not domain specific, and can't be used. See [1]. We need to insert the defaults in directive options. - We want to preserve the original directive options, and present those in examples documentation. However, in all testing, we need to amend the defaults. Note that the parser selects the -x language option based on domain and filename suffix. [1] #255
|
Got a better idea, dropping this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For starters, define the language stardard to use. Use c17 and c++17, fairly arbitrarily. Tests can override this. We can remove the std option from template.yaml.
This is a bit more convoluted than should be necessary, for a few reasons:
Extension tests use the directive options from directive string. For that, the defaults should be specified in conf.py, but hawkmoth_clang is not domain specific, and can't be used. See [1]. We need to insert the defaults in directive options.
We want to preserve the original directive options, and present those in examples documentation. However, in all testing, we need to amend the defaults.
Note that the parser selects the -x language option based on domain and filename suffix.
[1] #255